feat(wallet)!: createKey from private key #1301

genaris · 2023-02-14T16:19:49Z

This is being added to provide a way of creating deterministic keys in a similar way than indy-sdk, as our current findings are that it is actually using the seed as a secret key.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

codecov-commenter · 2023-02-14T17:11:09Z

Codecov Report

Merging #1301 (1a0e904) into main (64a5da9) will increase coverage by 0.01%.
The diff coverage is 77.58%.

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
+ Coverage   85.16%   85.18%   +0.01%     
==========================================
  Files         835      835              
  Lines       20738    20770      +32     
  Branches     3535     3557      +22     
==========================================
+ Hits        17662    17693      +31     
- Misses       3069     3070       +1     
  Partials        7        7

Impacted Files	Coverage Δ
...ckages/indy-sdk/src/dids/IndySdkSovDidRegistrar.ts	`17.18% <0.00%> (-0.28%)`	⬇️
packages/core/src/wallet/IndyWallet.ts	`55.76% <62.50%> (+0.83%)`	⬆️
packages/indy-sdk/src/wallet/IndySdkWallet.ts	`40.30% <62.50%> (+1.15%)`	⬆️
...es/bbs-signatures/src/Bls12381g2SigningProvider.ts	`92.85% <75.00%> (-3.44%)`	⬇️
packages/askar/src/wallet/AskarWallet.ts	`62.59% <88.88%> (+1.65%)`	⬆️
...kages/indy-vdr/src/dids/IndyVdrIndyDidRegistrar.ts	`81.81% <88.88%> (-0.11%)`	⬇️
...re/src/modules/dids/methods/key/KeyDidRegistrar.ts	`93.10% <100.00%> (-2.90%)`	⬇️
.../src/modules/dids/methods/peer/PeerDidRegistrar.ts	`96.22% <100.00%> (-1.74%)`	⬇️
...modules/dids/methods/sov/IndySdkSovDidRegistrar.ts	`93.93% <100.00%> (+0.09%)`	⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

TimoGlastra · 2023-02-14T19:00:42Z

packages/askar/src/wallet/__tests__/AskarWallet.test.ts

+  test('Create ed25519 keypair from secret bytes', async () => {
+    await expect(
+      askarWallet.createKey({
+        secretKey: TypedArrayEncoder.fromString('2103de41b4ae37e8e28586d84a342b67'),


If secretKey is bytes, should seed also be bytes? Or other other way around?

Wel, it was added as a direct replacement from seed so that´s why it came from a string, but might be better to use Buffer or Key as other methods from Wallet.

Do we still want to make this change? Or maybe in another PR?

Ah yes, I'll move seed to Buffer as well. I think it will be better to enforce the use of characters other than alphanumeric. After all we are in breaking time!

TimoGlastra · 2023-02-14T19:03:48Z

packages/askar/src/wallet/AskarWallet.ts

+        if (seed && secretKey) {
+          throw new AriesFrameworkError('Only one of seed and secretKey can be set')
+        }
+
+        // Create key
+        const key = secretKey
+          ? AskarKey.fromSecretBytes({ secretKey, algorithm })
+          : seed
+          ? AskarKey.fromSeed({ seed: Buffer.from(seed), algorithm })


Should we also update the indySdk wallet to use the secretKey as the seed? I think that aligns better with the internal implementation and makes it more consistent.

It's a bit weird. But I think we should be careful with introducing this inconsistency in the API.

Now we know what´s the actual behaviour of indy-sdk, I think it will be better to name the things as they really are. So I´m OK on adding this secretKey (being a Key or Buffer) to the geneic WalletCreateKeyOptions.

But are we going to support both seed and secretKey in the interface and throw error when a non supported parameter is specified? For instance, if we specify seed for a IndyWallet we know it will not be treated as a seed, so should we reject it and leverage Indy users to provide a secretKey instead?

And what about the fallback to SigningProviders? Current interface only supports seed. I don´t see a limitation to add secretKey as an input there, but we´ll need to implement it.

There is also another interface using seed incorrectly: DidConfig, which we are using in initPublicDid method, that will be deprecated soon so I guess we should not care about it.

Yeah good points. I thinkg throwing an error in the indy-sdk seems fine. Then in Askar we can implement both and we could also add the secretKey/seed paramteres to the signing provider.

One thing we should look at is that it used privateKey there, and we're using secretKey here. I'm more used to privateKey, but if we go for secretKey we may want to make that consistent across the framework.

Also, we could also call it importKey or something as you're not really creating a key when you create it based on the secret bytes

I think for the moment we can go with an optional privateKey (as Uint8Array) for WalletCreateKeyOptions and throw error if using seed in IndyWallet, and throw error if using privateKey with signing providers (I didn't look a lot but didn't find a way to provide a private key in bbs-signatures).

If we create it from private key, we already have the private key rigt, so it should work with the signing providers I'd assume?

I think so. We can make CreateKeyPairOptions interface from SigningProvider to accept both (in the same way Wallet does now) and then depending on each implementation it will be supported or not.

some questions still

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

TimoGlastra

Left some final comments, but good to merge 👍

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

TimoGlastra · 2023-02-19T16:14:22Z

packages/core/src/modules/dids/methods/key/KeyDidRegistrar.ts

@@ -39,10 +41,22 @@ export class KeyDidRegistrar implements DidRegistrar {
      }
    }

+    if (privateKey && (typeof privateKey !== 'object' || privateKey.length !== 32)) {


Suggested change

if (privateKey && (typeof privateKey !== 'object' || privateKey.length !== 32)) {

if (privateKey && (!Buffer.isBuffer(privateKey) || privateKey.length !== 32) {

I'm not sure if the privateKey always needs to be 32 bytes? It depends on the key type I guess, so maybe we need to handle this in the wallet?

TimoGlastra · 2023-02-19T16:15:35Z

packages/core/src/modules/dids/methods/key/KeyDidRegistrar.ts

+            seed: options.secret?.seed?.toString(),
+            privateKey: options.secret?.privateKey?.toString(),


If we pass a buffer, we can also return a buffer I think?

TimoGlastra · 2023-02-19T16:17:00Z

packages/core/src/modules/dids/methods/sov/IndySdkSovDidRegistrar.ts


-    if (seed && (typeof seed !== 'string' || seed.length !== 32)) {
+    if (privateKey && (typeof privateKey !== 'object' || privateKey.length !== 32)) {


In addition to validting in the wallet, we could also look at creating util methods isValidSeed, isValidPrivateKey. But I'm not sure if the seed / privateKey is always the same for each key type...

commit 0351eec Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 15 12:02:50 2023 -0300 fix: connection id in sessions for new connections (openwallet-foundation#1383) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit f27fb99 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 15 09:23:10 2023 -0300 feat: basic message pthid/thid support (openwallet-foundation#1381) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit d59366a Author: Jim Ezesinachi <ezesinachijim@gmail.com> Date: Wed Mar 15 11:04:52 2023 +0100 docs: fix example usage of indy-sdk-react-native package (openwallet-foundation#1382) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit a4204ef Author: Timo Glastra <timo@animo.id> Date: Sat Mar 11 16:31:09 2023 +0100 fix: remove named capture groups (openwallet-foundation#1378) named capture groups are only supported in more recent versions of hermes Signed-off-by: Timo Glastra <timo@animo.id> commit dd6c020 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Mar 11 11:57:37 2023 -0300 feat(anoncreds-rs): use new API methods for json conversion (openwallet-foundation#1373) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 122cdde Author: Timo Glastra <timo@animo.id> Date: Sat Mar 11 13:31:09 2023 +0100 fix: return HTTP 415 if unsupported content type (openwallet-foundation#1313) Signed-off-by: Timo Glastra <timo@animo.id> commit 582c711 Author: Mo <10432473+morrieinmaas@users.noreply.github.com> Date: Sat Mar 11 12:08:02 2023 +0100 feat: outbound message send via session (openwallet-foundation#1335) Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Moriarty <moritz@animo.id> commit 19cefa5 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Mar 11 07:20:49 2023 -0300 feat(askar): import/export wallet support for SQLite (openwallet-foundation#1377) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c72ba14 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 17:40:03 2023 +0100 fix(askar): custom error handling (openwallet-foundation#1372) Signed-off-by: Timo Glastra <timo@animo.id> commit 39c4ed0 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 16:52:12 2023 +0100 feat(indy-vdr)!: extend did:indy support (openwallet-foundation#1362) Signed-off-by: Timo Glastra <timo@animo.id> commit 01669a7 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 14:48:34 2023 +0100 test: increase timeout to 120 seconds (openwallet-foundation#1375) Signed-off-by: Timo Glastra <timo@animo.id> commit 953069a Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Mar 6 10:28:30 2023 -0300 fix(core): repository event when calling deleteById (openwallet-foundation#1356) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c133538 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Mar 6 08:26:42 2023 -0300 fix(anoncreds): Buffer not imported from core (openwallet-foundation#1367) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 8f6b344 Author: Timo Glastra <timo@animo.id> Date: Fri Mar 3 12:15:58 2023 +0100 feat(indy-sdk)!: move to did:indy with limited support (openwallet-foundation#1347) Signed-off-by: Timo Glastra <timo@animo.id> commit 7795975 Author: Martin Auer <martin.auer97@gmail.com> Date: Fri Mar 3 11:07:43 2023 +0100 fix(tenant): Correctly configure storage for multi tenant agents (openwallet-foundation#1359) Fixes hyperledger#1353 Signed-off-by: martin auer <martin.auer97@gmail.com> commit cb4e469 Author: Timo Glastra <timo@animo.id> Date: Thu Mar 2 22:38:14 2023 +0100 test: various improvements (openwallet-foundation#1361) Signed-off-by: Timo Glastra <timo@animo.id> commit fd13bb8 Author: Ariel Gentile <gentilester@gmail.com> Date: Thu Mar 2 17:00:57 2023 -0300 feat(oob): implicit invitations (openwallet-foundation#1348) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 18abb18 Author: Pritam Singh <43764373+Zzocker@users.noreply.github.com> Date: Thu Mar 2 22:11:20 2023 +0530 fix: isNewSocket logic (openwallet-foundation#1355) Signed-off-by: Pritam Singh <pkspritam16@gmail.com> commit 2c792fe Author: Martin Auer <martin.auer97@gmail.com> Date: Thu Mar 2 14:29:05 2023 +0100 refactor!: remove getKeyDidMappingByVerificationMethod (openwallet-foundation#1350) Signed-off-by: martin auer <martin.auer97@gmail.com> commit 78ecf1e Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 1 18:44:26 2023 -0300 refactor!: remove Dispatcher.registerMessageHandler (openwallet-foundation#1354) BREAKING CHANGE: `Dispatcher.registerMessageHandler` has been removed in favour of `MessageHandlerRegistry.registerMessageHandler`. If you want to register message handlers in an extension module, you can use directly `agentContext.dependencyManager.registerMessageHandlers`. Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 1bda3f0 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 27 15:35:16 2023 -0300 fix(anoncreds-rs): save revocation registry index (openwallet-foundation#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 4ab3b54 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 27 13:23:47 2023 +0100 refactor!: set default outbound content type to didcomm v1 (openwallet-foundation#1314) Signed-off-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: Agent default outbound content type has been changed to DIDComm V1. If you want to use former behaviour, you can do it so by manually setting `didcommMimeType` in `Agent`'s init config: ``` const agent = new Agent({ config: { ... didCommMimeType: DidCommMimeType.V0 }, ... }) ``` commit 254f661 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Feb 25 11:49:36 2023 -0300 fix(indy-sdk): import from core (openwallet-foundation#1346) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 21d4bf7 Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 22:20:54 2023 +0100 feat!: allow to import created dids (and remove legacy `publicDidSeed`) (openwallet-foundation#1325) Signed-off-by: Timo Glastra <timo@animo.id> commit dc60acb Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 20:50:28 2023 +0100 build(anoncreds): remove node package from deps (openwallet-foundation#1339) Signed-off-by: Timo Glastra <timo@animo.id> commit e14d853 Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 17:59:30 2023 +0100 test: increase indy-sdk timeout (openwallet-foundation#1345) Signed-off-by: Timo Glastra <timo@animo.id> commit d38ecb1 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 24 09:12:40 2023 -0300 fix(anoncreds): include prover_did for legacy indy (openwallet-foundation#1342) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit da8f2ad Author: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Date: Fri Feb 24 13:01:47 2023 +0200 fix: create new socket if socket state is 'closing' (openwallet-foundation#1337) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> commit cac2ec3 Author: Martin Auer <martin.auer97@gmail.com> Date: Fri Feb 24 11:11:28 2023 +0100 refactor(core)!: remove deprecated injectionContainer prop (openwallet-foundation#1344) Signed-off-by: martin auer <martin.auer97@gmail.com> commit d5e34ff Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 24 06:19:32 2023 -0300 test(indy-sdk): wait before resolving ledger objects (openwallet-foundation#1340) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 518e5e4 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Feb 22 04:36:33 2023 -0300 fix: expose indy pool configs and action menu messages (openwallet-foundation#1333) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 1c6aeae Author: Ariel Gentile <gentilester@gmail.com> Date: Tue Feb 21 19:18:19 2023 -0300 fix(askar): anoncrypt messages unpacking (openwallet-foundation#1332) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit fb7ee50 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Tue Feb 21 15:39:14 2023 +0100 feat: IndyVdrAnonCredsRegistry revocation methods (openwallet-foundation#1328) Signed-off-by: Victor Anene <victor@animo.id> commit 64e20f1 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 17:07:30 2023 +0100 fix!: don't emit legacy did:sov prefix for new protocols (openwallet-foundation#1245) Signed-off-by: Timo Glastra <timo@animo.id> commit c0e5339 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 20 09:04:20 2023 -0300 fix: seed and private key validation and return type in registrars (openwallet-foundation#1324) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit edf392f Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 12:14:21 2023 +0100 refactor: remove master secret id from wallet (openwallet-foundation#1320) Signed-off-by: Timo Glastra <timo@animo.id> commit b6d66b1 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 00:59:42 2023 +0100 refactor!: remove indy from core (openwallet-foundation#1286) Signed-off-by: Timo Glastra <timo@animo.id> commit 616b908 Author: Ariel Gentile <gentilester@gmail.com> Date: Sun Feb 19 13:27:16 2023 -0300 feat(wallet)!: createKey from private key (openwallet-foundation#1301) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 64a5da9 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Feb 18 16:54:25 2023 -0300 fix(samples): dummy module response message type (openwallet-foundation#1321) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit ff5596d Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 17 23:10:09 2023 -0300 feat!: add data, cache and temp dirs to FileSystem (openwallet-foundation#1306) Signed-off-by: Ariel Gentile <gentilester@gmail.com> BREAKING CHANGE: Agent-produced files will now be divided in different system paths depending on their nature: data, temp and cache. Previously, they were located at a single location, defaulting to a temporary directory. If you specified a custom path in `FileSystem` object constructor, you now must provide an object containing `baseDataPath`, `baseTempPath` and `baseCachePath`. They can point to the same path, although it's recommended to specify different path to avoid future file clashes. commit af384e8 Author: Timo Glastra <timo@animo.id> Date: Sat Feb 18 01:32:45 2023 +0100 fix: loosen base64 validation (openwallet-foundation#1312) Signed-off-by: Timo Glastra <timo@animo.id> commit 229ed1b Author: Timo Glastra <timo@animo.id> Date: Fri Feb 17 21:31:47 2023 +0100 fix: thread id improvements (openwallet-foundation#1311) Signed-off-by: Timo Glastra <timo@animo.id> commit 1d782f5 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Fri Feb 17 20:01:35 2023 +0100 feat: add fetch indy schema method (openwallet-foundation#1290) Signed-off-by: Victor Anene <victor@animo.id> commit 3e02227 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Feb 15 20:14:47 2023 -0300 fix: imports from core (openwallet-foundation#1303) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 4ac5332 Author: Jason C. Leach <jason.leach@fullboar.ca> Date: Wed Feb 15 14:11:41 2023 -0800 feat: add devcontainer support (openwallet-foundation#1282) Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca> commit efab8dd Author: Ariel Gentile <gentilester@gmail.com> Date: Tue Feb 14 19:49:59 2023 -0300 feat(indy-vdr): resolver and registrar for did:indy (openwallet-foundation#1253) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit a487705 Author: Timo Glastra <timo@animo.id> Date: Tue Feb 14 10:57:22 2023 +0100 docs: update readme (openwallet-foundation#1298) docs: update reaadme Signed-off-by: Timo Glastra <timo@animo.id> commit ecce0a7 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 13 19:01:39 2023 -0300 fix(askar): generate nonce suitable for anoncreds (openwallet-foundation#1295) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c63350c Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 20:58:46 2023 +0100 test: add anoncreds restriction test (openwallet-foundation#1294) Signed-off-by: Timo Glastra <timo@animo.id> commit b570e0f Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 19:49:21 2023 +0100 fix(indy-vdr): export relevant packages from root (openwallet-foundation#1291) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit c72fd74 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 18:40:44 2023 +0100 feat(anoncreds): legacy indy proof format service (openwallet-foundation#1283) Signed-off-by: Timo Glastra <timo@animo.id> commit dfb3eaf Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 16:23:41 2023 +0100 build(indy-sdk): set private to false (openwallet-foundation#1293) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit 231145f Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 13 10:22:44 2023 -0300 chore: make askar, anoncreds(-rs), indy-vdr packages public (openwallet-foundation#1292) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit fb8d58b Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 12:57:35 2023 +0100 refactor(proofs)!: generalize proofs api and improve consistency with credentials module (openwallet-foundation#1279) Signed-off-by: Timo Glastra <timo@animo.id> commit 51030d4 Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 11:43:02 2023 +0100 feat(indy-vdr): module registration (openwallet-foundation#1285) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit d61f6ed Author: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Date: Mon Feb 13 09:23:17 2023 +0100 chore(core): remove useless file (openwallet-foundation#1288) commit 30857b9 Author: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Date: Sat Feb 11 22:50:10 2023 +0100 fix(transport)!: added docs moved connection to connectionId (openwallet-foundation#1222) Signed-off-by: blu3beri <blu3beri@proton.me> commit efe0271 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 10 19:15:36 2023 -0300 feat: add anoncreds-rs package (openwallet-foundation#1275) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 2669d7d Author: KolbyRKunz <KolbyKunz@yahoo.com> Date: Fri Feb 10 14:14:59 2023 -0700 fix: set updateAt on records when updating a record (openwallet-foundation#1272) Signed-off-by: KolbyRKunz <kolbykunz@yahoo.com> commit 1d487b1 Author: Jim Ezesinachi <jim@animo.id> Date: Fri Feb 10 20:21:20 2023 +0100 feat: added endpoint setter to agent InitConfig (openwallet-foundation#1278) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit 86cb9d0 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 10 11:13:44 2023 -0300 ci: increase maximum heap memory for node (openwallet-foundation#1280) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit d056316 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Fri Feb 10 01:31:43 2023 +0100 feat(indy-vdr): add IndyVdrAnonCredsRegistry (openwallet-foundation#1270) Signed-off-by: Timo Glastra <timo@animo.id> commit f18d189 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 6 23:34:21 2023 -0300 feat: add initial askar package (openwallet-foundation#1211) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 115d897 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 6 23:45:01 2023 +0000 build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (openwallet-foundation#1258) commit 3d86e78 Author: Karim Stekelenburg <karim@animo.id> Date: Tue Feb 7 00:09:24 2023 +0100 feat(openid4vc-client): pre-authorized (openwallet-foundation#1243) This PR adds support for the `pre-authorized` OpenID for Verifiable Credentials issuance flow to the new `openid4vc-client` module. Here are some highlights of the work: - Allows the user to execute the entire `pre-authorized` flow by calling a single method. - Adds a happy-flow test - HTTP(S) requests and responses are mocked using a network mocking library called [nock](https://github.com/nock/nock) - Because the JSON-LD credential that is received is expanded by the `W3cCredentialService`, I've added a few new contexts to our test document loader. - Not-so-happy-flow tests will be added later on. If you have any suggestions for edge cases that deserve testing, feel free to drop a comment. - Modifies the `JwsService` - The `JwsService` was geared towards a very specific use case. I've generalized its API so it's usable for a wider range of applications. - All pre-existing tests and calls to the `JwsService` have been updated. It's worth noting that I have had to add some `@ts-ignore` statements here and there to get around some incomplete types in the `OpenID4VCI-Client` library we're using. Once these issues have been resolved in the client library, they will be removed. **Work funded by the government of Ontario** --------- Signed-off-by: Karim Stekelenburg <karim@animo.id> Co-authored-by: Timo Glastra <timo@animo.id> commit 7f65ba9 Author: Jim Ezesinachi <jim@animo.id> Date: Mon Feb 6 22:27:03 2023 +0100 feat: optional routing for legacy connectionless invitation (openwallet-foundation#1271) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit 3a4c5ec Author: Timo Glastra <timo@animo.id> Date: Mon Feb 6 21:49:12 2023 +0100 feat(anoncreds): add anoncreds API (openwallet-foundation#1232) Signed-off-by: Timo Glastra <timo@animo.id>

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris added 2 commits February 14, 2023 12:49

feat(askar): create key from secret key

29be3e6

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

test: handle errors and check parameters

b50b6b8

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris requested a review from a team as a code owner February 14, 2023 16:19

TimoGlastra previously approved these changes Feb 14, 2023

View reviewed changes

genaris added 3 commits February 16, 2023 08:11

Merge branch 'main' into feat/askar-key-from-secret

19c123e

Merge branch 'main' into feat/askar-key-from-secret

2ee445e

feat!: replace seed by privateKey in indy based classes and tests

3aba2cc

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris changed the title ~~feat(askar): createKey from secret bytes~~ feat(wallet)!: createKey from private key Feb 18, 2023

genaris added 3 commits February 17, 2023 23:25

Merge branch 'main' into feat/askar-key-from-secret

5e555d3

fix: use privateKey for key creation

db60ade

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

fix: use seed for bls key and privateKey for ed25519

4b05b5b

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

genaris mentioned this pull request Feb 18, 2023

refactor!: remove indy from core #1286

Merged

Merge branch 'main' into feat/askar-key-from-secret

8414d64

TimoGlastra approved these changes Feb 18, 2023

View reviewed changes

use seed as Buffer and add privateKey as option for did registrars

1a0e904

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

TimoGlastra reviewed Feb 19, 2023

View reviewed changes

TimoGlastra merged commit 616b908 into openwallet-foundation:main Feb 19, 2023

genaris mentioned this pull request Feb 19, 2023

fix: seed and private key validation and return type in registrars #1324

Merged

genaris deleted the feat/askar-key-from-secret branch February 24, 2023 18:47

karimStekelenburg pushed a commit to karimStekelenburg/aries-framework-javascript that referenced this pull request Mar 17, 2023

feat(wallet)!: createKey from private key (openwallet-foundation#1301)

5b76c26

Signed-off-by: Ariel Gentile <gentilester@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wallet)!: createKey from private key #1301

feat(wallet)!: createKey from private key #1301

genaris commented Feb 14, 2023

codecov-commenter commented Feb 14, 2023 •

edited

Loading

TimoGlastra Feb 14, 2023

genaris Feb 14, 2023

TimoGlastra Feb 18, 2023

genaris Feb 18, 2023

TimoGlastra Feb 14, 2023

genaris Feb 14, 2023

TimoGlastra Feb 17, 2023

TimoGlastra Feb 17, 2023

genaris Feb 17, 2023

TimoGlastra Feb 18, 2023

genaris Feb 18, 2023

TimoGlastra left a comment

TimoGlastra Feb 19, 2023

TimoGlastra Feb 19, 2023

TimoGlastra Feb 19, 2023

TimoGlastra Feb 19, 2023

	if (privateKey && (typeof privateKey !== 'object' \|\| privateKey.length !== 32)) {
	if (privateKey && (!Buffer.isBuffer(privateKey) \|\| privateKey.length !== 32) {

		seed: options.secret?.seed?.toString(),
		privateKey: options.secret?.privateKey?.toString(),


		if (seed && (typeof seed !== 'string' \|\| seed.length !== 32)) {
		if (privateKey && (typeof privateKey !== 'object' \|\| privateKey.length !== 32)) {

feat(wallet)!: createKey from private key #1301

feat(wallet)!: createKey from private key #1301

Conversation

genaris commented Feb 14, 2023

codecov-commenter commented Feb 14, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimoGlastra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 14, 2023 •

edited

Loading