fix: unqualified indy revRegDefId in migration #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
|
I added a patch with these changes today and so far deleting credentials appears to be working flawlessly now! Thank you for this, much appreciated |
TimoGlastra
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Seems to be some nasty bugs related to the unqualified/qualified identifiers and migration of anoncreds credentials.
Sorry for the inconvenience from our side in releasing this code too soon before it was properly tested, lesson learned!
Thanks for looking into this @genaris! 🙌
|
Hmm seems the DCO check is not working (also not in Askar repo) |
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
It seems this problem should be fixed shortly: dcoapp/app#211 |
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, the fix done in 0.5.3 for Indy credentials migration was not enough for some Indy revocable credentials, since it is failing to apply qualified/unqualified revocation registry identifier tags into Credential Exchange record and, therefore, not effectively updating its bindings to the W3C credential.
This happens, for instance, when migrating from 0.4.2 to 0.5.3 the credentials received in BCGov Showcase and attempting to delete the credentials associated to a credential exchange.
Fixes #1882
cc @wadeking98 @bryce-mcmath