Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unqualified indy revRegDefId in migration #1887

Merged
merged 5 commits into from
Jun 5, 2024
Merged

fix: unqualified indy revRegDefId in migration #1887

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ad0582
fix: unqualified indy revRegDefId in migration
genaris Jun 2, 2024
b302311
Merge branch 'main' into fix/unqualified-revregdefid
genaris Jun 4, 2024
c0a0286
test: add revocable credentials
genaris Jun 4, 2024
24485ea
test: minor change
genaris Jun 5, 2024
eaf0dc4
ci: trigger DCO
genaris Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions packages/anoncreds/src/updates/0.4-0.5/anonCredsCredentialRecord.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@ import { fetchCredentialDefinition } from '../../utils/anonCredsObjects'
import {
getIndyNamespaceFromIndyDid,
getQualifiedDidIndyDid,
getUnQualifiedDidIndyDid,
getUnqualifiedRevocationRegistryDefinitionId,
isIndyDid,
isUnqualifiedCredentialDefinitionId,
isUnqualifiedIndyDid,
parseIndyRevocationRegistryId,
} from '../../utils/indyIdentifiers'
import { W3cAnonCredsCredentialMetadataKey } from '../../utils/metadata'
import { getW3cRecordAnonCredsTags } from '../../utils/w3cAnonCredsUtils'
Expand Down Expand Up @@ -156,12 +157,20 @@ async function migrateLegacyToW3cCredential(agentContext: AgentContext, legacyRe
credentialRecordId: w3cCredentialRecord.id,
}

// If using unqualified dids, store both qualified/unqualified revRegId forms
// If using Indy dids, store both qualified/unqualified revRegId forms
// to allow retrieving it from revocation notification service
if (legacyTags.revocationRegistryId && indyNamespace) {
const { credentialDefinitionTag, namespaceIdentifier, revocationRegistryTag, schemaSeqNo } =
parseIndyRevocationRegistryId(legacyTags.revocationRegistryId)

relatedCredentialExchangeRecord.setTags({
anonCredsRevocationRegistryId: getQualifiedDidIndyDid(legacyTags.revocationRegistryId, indyNamespace),
anonCredsUnqualifiedRevocationRegistryId: getUnQualifiedDidIndyDid(legacyTags.revocationRegistryId),
anonCredsUnqualifiedRevocationRegistryId: getUnqualifiedRevocationRegistryDefinitionId(
namespaceIdentifier,
schemaSeqNo,
credentialDefinitionTag,
revocationRegistryTag
),
})
}

Expand Down Expand Up @@ -190,13 +199,14 @@ export async function storeAnonCredsInW3cFormatV0_5<Agent extends BaseAgent>(age
try {
await migrateLegacyToW3cCredential(agent.context, record)
await anoncredsRepository.delete(agent.context, record)
agent.config.logger.debug(
`Successfully migrated w3c credential record with id ${record.id} to storage version 0.5`
)
} catch (error) {
agent.config.logger.error(
`Failed to migrate w3c credential record with id ${record.id} to storage version 0.5`,
error
)
}

agent.config.logger.debug(`Successfully migrated w3c credential record with id ${record.id} to storage version 0.5`)
}
}
Loading