Convert unit tests to typescript. #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
mathspeak-plus-unit-test-work
branch
from
73ba1dd to
e62611e
Compare
Also move the public/support/assert.js to test/support/assert.ts and have it export its symbols for import in the tests instead of loading it in the browser.
drgrice1
force-pushed
the
mathspeak-plus-unit-test-work
branch
from
e62611e to
00769b3
Compare
Alex-Jordan
approved these changes
Dec 16, 2024
|
If someone does want to test this, run This doesn't change any actual code in the build of MathQuill used by webwork2 and pg (other than a prettier formatting issue in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #33 since it would conflict rather heavily with that pull request if it didn't (and it was created after that one).
I have been meaning to do this for a while, and it did reveal some things that needed to be fixed in the code (those were added in #33).
This does not require an npm package update since it is development tools only and doesn't change any of the code.