openwebwork · drgrice1 · Nov 9, 2024 · Nov 9, 2024 · Nov 12, 2024 · Nov 12, 2024
diff --git a/.editorconfig b/.editorconfig
@@ -9,5 +9,5 @@ indent_style = tab
 indent_size = 4
 trim_trailing_whitespace = true
 
-[*.md]
+[*.{md,yml}]
 indent_style = space
diff --git a/.github/workflows/check-formats.yml b/.github/workflows/check-formats.yml
@@ -0,0 +1,27 @@
+---
+name: Check Formatting of Code Base
+
+defaults:
+    run:
+        shell: bash
+
+on:
+    push:
+        branches-ignore: [main]
+    pull_request:
+
+jobs:
+    prettier:
+        name: Check TypeScript, JavaScript, style, and HTML file formatting with prettier
+        runs-on: ubuntu-24.04
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
+            - name: Install Node
+              uses: actions/setup-node@v4
+              with:
+                  node-version: '20'
+            - name: Install Dependencies
+              run: npm ci --ignore-scripts
+            - name: Check formatting with prettier
+              run: npm run format:check
diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -0,0 +1,27 @@
+---
+name: Lint Code Base
+
+defaults:
+    run:
+        shell: bash
+
+on:
+    push:
+        branches-ignore: [main]
+    pull_request:
+
+jobs:
+    eslint:
+        name: Lint TypeScript and JavaScript files with eslint and style files with stylelint
+        runs-on: ubuntu-24.04
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
+            - name: Install Node
+              uses: actions/setup-node@v4
+              with:
+                  node-version: '20'
+            - name: Install Dependencies and Build
+              run: npm ci --ignore-scripts && npm run build
+            - name: Lint files with eslint and stylelint
+              run: npm run lint:check
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -24,14 +24,19 @@
 		"build:web": "webpack --mode production",
 		"build": "npm run build:web && npm run build:lib",
 		"serve": "webpack serve --mode development",
-		"lint:eslint": "eslint ./src ./test ./public --fix",
+		"lint:eslint": "eslint ./src ./test --fix",
+		"lint:eslint:check": "eslint ./src ./test",
 		"lint:stylelint": "stylelint \"./src/**/*.less\" \"./public/**/*.css\" \"./public/**/*.html\" --fix",
+		"lint:stylelint:check": "stylelint \"./src/**/*.less\" \"./public/**/*.css\" \"./public/**/*.html\"",
 		"lint": "npm run lint:eslint && npm run lint:stylelint",
-		"format": "prettier --write ."
+		"lint:check": "npm run lint:eslint:check && npm run lint:stylelint:check",
+		"format": "prettier --write .",
+		"format:check": "prettier --check ."
 	},
 	"devDependencies": {
 		"@awmottaz/prettier-plugin-void-html": "^1.6.1",
 		"@stylistic/eslint-plugin": "^2.7.2",
+		"@types/mocha": "^10.0.9",
 		"copy-webpack-plugin": "^12.0.2",
 		"css-loader": "^7.1.2",
 		"css-minimizer-webpack-plugin": "^7.0.0",

diff --git a/public/demo.html b/public/demo.html
@@ -7,7 +7,7 @@
 
 		<title>MathQuill Demo</title>
 
-		<link rel="stylesheet" href="support/home.css">
+		<link rel="stylesheet" href="home.css">
 		<link rel="stylesheet" href="mathquill.css">
 
 		<style>

diff --git a/public/support/home.css → public/home.css b/public/support/home.css → public/home.css
diff --git a/public/support/assert.js b/public/support/assert.js
diff --git a/public/unit-test.html b/public/unit-test.html
@@ -11,23 +11,9 @@
 		<script src="mocha/mocha.js"></script>
 		<link rel="stylesheet" href="mocha/mocha.css">
 
-		<!-- home-grown assertions -->
-		<script src="support/assert.js"></script>
-
-		<!-- configure mocha -->
-		<script>
-			window.post_xunit_to = new URLSearchParams(location.search).get('post_xunit_to');
-			mocha.setup({ ui: 'tdd', reporter: post_xunit_to ? 'xunit' : 'html', bail: false });
-		</script>
-
 		<!-- include the library with the tests inlined -->
-		<script id="mathquill" src="mathquill.test.js"></script>
-
-		<!-- include MathQuill-basic -->
+		<script id="mathquill" src="mathquill.test.js" defer></script>
 		<link rel="stylesheet" href="mathquill.css">
-		<script>
-			MQ = MathQuill.getInterface();
-		</script>
 	</head>
 
 	<body>
@@ -36,6 +22,10 @@ <h1>Unit Tests</h1>
 		<div id="mock"></div>
 
 		<script>
+			// configure mocha
+			const post_xunit_to = new URLSearchParams(location.search).get('post_xunit_to');
+			mocha.setup({ ui: 'tdd', reporter: post_xunit_to ? 'xunit' : 'html', bail: false });
+
 			teardown(() => {
 				const mock = document.getElementById('mock');
 				while (mock.firstChild) mock.firstChild.remove();

diff --git a/public/visual-test.html b/public/visual-test.html
@@ -7,7 +7,7 @@
 
 		<title>MathQuill Visual Test Page</title>
 
-		<link rel="stylesheet" href="support/home.css">
+		<link rel="stylesheet" href="home.css">
 		<link rel="stylesheet" href="mathquill.css">
 
 		<script src="mathquill.js"></script>

diff --git a/src/commands/mathElements.ts b/src/commands/mathElements.ts
@@ -1436,9 +1436,10 @@ const BracketMixin = <TBase extends Constructor<MathCommand>>(Base: TBase) =>
 
 		getSymbol(side?: Direction) {
 			return (
-				(SVG_SYMBOLS[this.sides[side || 'right'].ch] as
-					| { width: string; html: string }
-					| undefined) || { width: '0', html: '' }
+				(SVG_SYMBOLS[this.sides[side || 'right'].ch] as { width: string; html: string } | undefined) || {
+					width: '0',
+					html: ''
+				}
 			);
 		}
 

diff --git a/src/css/fontBasic.less b/src/css/fontBasic.less
diff --git a/src/css/mainBasic.less b/src/css/mainBasic.less