lpac: lpac-libmbim-wrapper doesn't work

[bam80]

Maintainer: @blocktrron

Description:
lpac.sh wrapper is currently installed by the name of the binary in /usr/bin/lpac:

packages/utils/lpac/Makefile

Line 57 in b1635b8

$(INSTALL_BIN) ./files/lpac.sh $(1)/usr/bin/lpac

This creates problem as the wrapper overrides env variables which can be set by other upper wrappers.

For now, https://github.com/stich86/lpac-libmbim-wrapper/ doesn't work.

lpac.sh must not mask real binary - instead, it should be installed separately.

[blocktrron]

Wrapping the command is to enable usage with uci.

Looking at the project you are referring to, please make https://github.com/stich86/lpac-libmbim-wrapper/blob/main/lpac-mbim#L119C5-L119C8 compatible to supply a --lpac-path argument.

[bam80]

Wrapping the command is to enable usage with uci.

Still, the path is not required to be the same as the binary, right? Use whatever path for your wrapper, but do not touch the binary path, it's not yours.

I think the upstream project behavior is correct, and shouldn't need changes.
Any wrapper should be able to rely on standard path for the binary, adopting it just for the purpose of your hack shouldn't be needed.

If I'm missing something, please let me know.

[blocktrron]

Use whatever path for your wrapper, but do not touch the binary path, it's not yours.

Where should i put it if not in PATH? Defaulting to configuration is sane behavior for OpenWrt, as this is where the configuration is read from.

If what you require is to pass the command-line arguments to the wrapper and override the envrionment it modifies, you can check if the variables are pre-set in the environment and skip the assignment from UCI in the wrapper.

[bam80]

Where should i put it if not in PATH?

the PATH is OK, just name it differently, I mean. Nobody will complain.

you can check if the variables are pre-set in the environment and skip the assignment from UCI in the wrapper.

I do not see why would we want to undertake such complexity if the fix is as simple as rename your wrapper.
Still need to see what others say. @BKPepe

Anyway, if you want to go that route, would you like to make the fix yourself?
Just make sure it's reviewed positively before merge, please.
Thank you.

[robimarko]

I quite like the wrapper as otherwise you gotta do it all manually which is quite annoying and beats the purpose of having a UCI configuration.

[bam80]

If what you require is to pass the command-line arguments to the wrapper and override the envrionment it modifies, you can check if the variables are pre-set in the environment and skip the assignment from UCI in the wrapper.

Please see #25046