lpac: don't override env vars in the wrapper #25046
Conversation
Some env variables sensitive for proper lpac functioning can be set by upper lpac wrappers such as lpac-libmbim-wrapper. If that's the case, we shouldn't override them, otherwise the wrapper won't work. Also, we shouldn't interpret values of the debug env variables. Instead, we just pass them as is if the corresponding uci optioins exist. fixes openwrt#25035 Signed-off-by: Andrey Butirsky <butirsky@gmail.com>
bam80
force-pushed
the
lpac_fix_wrapper
branch
from
124dbf5
to
a8b9fde
Compare
bam80
changed the title
|
I will have a look at this next week when I'm back. Regarding the change of the default values on the logging behavior - you can leave the default values from UCI set and just modify the env when it differs from the default value. This is possible, as the default iven in the packaged UCI file matches the behavior if the environment variables were unset. I can take care of that also, i have a straight-forward solution in my head. |
|
@blocktrron sorry I'm not sure I quite understand what you said. |
|
Sorry, i was quite busy last month (I did not forget about it though). See #25258 for my approach to tackle this. |
Some env variables sensitive for proper lpac functioning are set by upper lpac wrappers such as lpac-libmbim-wrapper.
If that's the case, we shouldn't override them, otherwise the wrapper won't work.
Also fixes problem with AT ADPU backend where debug is always on due AT_DEBUG is always exported.
Also, we shouldn't interpret values of the debug env
variables. Instead, we just pass them as is if the
corresponding uci optioins exist.
fixes #25035
Maintainer: @blocktrron
Description:
alternative to #25036