librespeed-cli: update the package and fix handling of unavailable servers #27832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For full changelog see: - https://github.com/librespeed/speedtest-cli/releases Signed-off-by: Richard Muzik <richard.muzik@turris.com>
muzikr
force-pushed
the
librespeed-cli-update-and-fix
branch
from
a710432 to
b686526
Compare
Contributor
Author
|
The package maintainer is former colleague, who does not work for us anymore. I would like to overtake the maintainer ship, if that would be all right. |
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94 Signed-off-by: Richard Muzik <richard.muzik@turris.com>
muzikr
force-pushed
the
librespeed-cli-update-and-fix
branch
from
b686526 to
0731eea
Compare
1715173329
approved these changes
Nov 11, 2025
Member
If @paper42 is not against it ;) |
BKPepe
changed the title
admin-turris
pushed a commit
to turris-cz/os-build
that referenced
this pull request
Nov 18, 2025
…e servers See commit messages in the patch. Already merged [1] in OpenWrt and should be removed when [2] will be dropped. [1] openwrt/packages#27832 [2] https://gitlab.nic.cz/turris/os/build/-/commit/759f04366337fd384afa52b06013a2bd6a9eb627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @paper42
(You can find this by checking the history of the package
Makefile.)Description:
Update to the newest version 1.0.12 and introduce patch, that handles unavailable servers.
In the current state, when the server does not respond to ping it can still be selected to test on. This results in failure as we have nothing to test against.
The patch was created from commit in librespeed/speedtest-cli MR [1].
[1] librespeed/speedtest-cli#94
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.