Integration of collective_broadcast into spec #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GleasonK
reviewed
Nov 27, 2023
GleasonK
requested changes
Nov 27, 2023
ghpvnist
requested changes
Nov 28, 2023
ghpvnist
requested changes
Nov 28, 2023
ghpvnist
approved these changes
Nov 29, 2023
|
Looks like there's a linting issue. We have a tool to format them automatically here; this command should do the trick: |
chaserileyroberts
force-pushed
the
chase/spec/cb
branch
from
0330ae7 to
f85128b
Compare
GleasonK
added a commit
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for RFC #1809. I did not add an interpreter implementation as @GleasonK specifically asked me to leave that for new staff joining his team.