Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: delete unreferenced file #11079

Merged
merged 1 commit into from
Oct 20, 2020
Merged

FreeBSD: delete unreferenced file #11079

merged 1 commit into from
Oct 20, 2020

Conversation

mattmacy
Copy link
Contributor

zfs_onexit_os.c was not deleted when it was removed from the build

Signed-off-by: Matt Macy mmacy@FreeBSD.org

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mattmacy
FreeBSD: delete unreferenced file
9a9712c 
zfs_onexit_os.c was not deleted when it was removed from the build

Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
ahrens
ahrens approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@ahrens ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@codecov
Copy link

codecov bot commented Oct 17, 2020 •
edited
Loading

Codecov Report

Merging #11079 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11079      +/-   ##
==========================================
- Coverage   79.67%   79.66%   -0.01%     
==========================================
  Files         397      397              
  Lines      125756   125756              
==========================================
- Hits       100191   100181      -10     
- Misses      25565    25575      +10
Flag Coverage Δ
#kernel 80.39% <ø> (-0.06%) ⬇️
#user 65.79% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/os/linux/spl/spl-zlib.c 55.35% <0.00%> (-28.58%) ⬇️
module/zfs/vdev_raidz_math.c 76.57% <0.00%> (-2.26%) ⬇️
lib/libzfs/libzfs_changelist.c 84.44% <0.00%> (-1.86%) ⬇️
module/zfs/vdev_removal.c 96.38% <0.00%> (-0.91%) ⬇️
module/zfs/vdev_trim.c 95.20% <0.00%> (-0.90%) ⬇️
module/zfs/spa_log_spacemap.c 93.40% <0.00%> (-0.86%) ⬇️
cmd/zed/agents/zfs_mod.c 76.89% <0.00%> (-0.67%) ⬇️
module/os/linux/spl/spl-kmem-cache.c 89.43% <0.00%> (-0.65%) ⬇️
module/zfs/dmu_tx.c 83.23% <0.00%> (-0.60%) ⬇️
module/zfs/arc.c 89.38% <0.00%> (-0.58%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e2b3d...9a9712c. Read the comment docs.

@ghost ghost added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 17, 2020
@behlendorf behlendorf merged commit ff2f542 into openzfs:master Oct 20, 2020
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Oct 30, 2020
@mattmacy
FreeBSD: delete unreferenced file
89cb786 
zfs_onexit_os.c was not deleted when it was removed from the build

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#11079
behlendorf pushed a commit that referenced this pull request Oct 30, 2020
@mattmacy @behlendorf
FreeBSD: delete unreferenced file
aeeada3 
zfs_onexit_os.c was not deleted when it was removed from the build

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes #11079
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@mattmacy @jsai20
FreeBSD: delete unreferenced file
9ac2da0 
zfs_onexit_os.c was not deleted when it was removed from the build

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#11079
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mattmacy
FreeBSD: delete unreferenced file
2c84491 
zfs_onexit_os.c was not deleted when it was removed from the build

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#11079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattmacy @behlendorf @ahrens