ZTS: Fix incorrect use of libtest in user_run by xattr_003_neg #11185

ghost · 2020-11-09T23:34:03Z

Motivation and Context

You can't use user_run to eval ksh functions defined in libtest unless you
include libtest in the user shell.

Description

Simplify user_run to preserve the environment and quote the command string
as one argument.

Fix xattr_003_neg by:

running ksh as the user
feeding it the commands to include libtest then run get_xattr
assert this fails
use variables for filenames so they don't change in the user's shell
don't log the contents of /etc/passwd
cleanup all byproducts

How Has This Been Tested?

I ran the userquota tests on FreeBSD and Linux and the projectquota tests on Linux.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

ghost · 2020-11-09T23:38:01Z

Fixed commit message

ghost · 2020-11-10T18:26:18Z

Huh, that's funny. I must have messed up my test procedure on FreeBSD, and I wonder what's different about Ubuntu 🤔

ghost · 2020-11-10T19:45:32Z

Nope I'm definitely seeing all the userquota tests pass on FreeBSD when I run them locally. Weird.

ghost · 2020-11-10T21:20:28Z

Rebased
Revert back to a full login when switching user, this seems to affect evaluation of redirection operators in a few tests
log_note the contents of the out and err files from the command to help future debugging

ghost · 2020-11-11T01:56:39Z

Well that fixed everything I broke, but it broke what I fixed 😄
I'll take another stab tomorrow.

ghost · 2020-11-24T18:31:45Z

I suspect the sudoers file on these bots is filtering out PATH from the environment or something. Maybe I can find a flag to explicitly keep it.

behlendorf · 2020-11-24T18:37:26Z

@freqlabs the CI should be customizing the sudoers file already to prevent exactly this. But perhaps it's not quite working as intended?

ghost · 2020-11-24T18:47:38Z

export PATH

The current user_run often does not work as expected. Commands are run in a different shell, with a different environment, and all output is discarded. Simplify user_run to retain the current environment, eliminate eval, and feed the command string into ksh. Enhance the logging for user_run so we can see out and err. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>

You can't use user_run to eval ksh functions defined in libtest unless you include libtest in the user shell. Fix xattr_003_neg by: * include libtest in the user shell * *then* run get_xattr * assert this fails * use variables for filenames so they don't change in the user's shell * don't log the contents of /etc/passwd * cleanup all byproducts Signed-off-by: Ryan Moeller <ryan@iXsystems.com>

ghost · 2021-03-12T16:38:01Z

Rebase
Use env to ensure correct PATH
Split changes into separate commits for libtest and xattr test

You can't use user_run to eval ksh functions defined in libtest unless you include libtest in the user shell. Fix xattr_003_neg by: * include libtest in the user shell * *then* run get_xattr * assert this fails * use variables for filenames so they don't change in the user's shell * don't log the contents of /etc/passwd * cleanup all byproducts Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11185

The current user_run often does not work as expected. Commands are run in a different shell, with a different environment, and all output is discarded. Simplify user_run to retain the current environment, eliminate eval, and feed the command string into ksh. Enhance the logging for user_run so we can see out and err. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11185

You can't use user_run to eval ksh functions defined in libtest unless you include libtest in the user shell. Fix xattr_003_neg by: * include libtest in the user shell * *then* run get_xattr * assert this fails * use variables for filenames so they don't change in the user's shell * don't log the contents of /etc/passwd * cleanup all byproducts Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11185