FreeBSD: Fix potential boot panic with bad label #14291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs fixing in 2.1, too. |
ghost
requested a review
from 
amotin
reviewed
Dec 21, 2022
|
amotin
approved these changes
Dec 22, 2022
amotin
reviewed
Dec 22, 2022
vdev_geom_read_pool_label() can leave NULL in configs. Check for it and skip consistently when generating rootconf. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
added
Status: Accepted
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
Dec 22, 2022
vdev_geom_read_pool_label() can leave NULL in configs. Check for it and skip consistently when generating rootconf. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#14291 (cherry picked from commit dc8c2f6)
ghost
mentioned this pull request
13 tasks
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 3, 2023
vdev_geom_read_pool_label() can leave NULL in configs. Check for it and skip consistently when generating rootconf. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#14291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://forums.FreeBSD.org/threads/nvme-adapter-with-hp-ex900-ssd-pci-e-nvme.85816/post-590379
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256368
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268116
vdev_geom_read_pool_label() can leave NULL in configs when it cannot read a label.
We then expect to be able to read the config and panic.
Description
Check for NULL and skip it when iterating through configs to generate rootconf.
How Has This Been Tested?
An early version of this fix was tested https://forums.FreeBSD.org/threads/nvme-adapter-with-hp-ex900-ssd-pci-e-nvme.85816/post-590379
Types of changes
Checklist:
Signed-off-by.