Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.8] FreeBSD: Fix potential boot panic with bad label #14316

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 22, 2022

vdev_geom_read_pool_label() can leave NULL in configs. Check for it and skip consistently when generating rootconf.

Reviewed-by: Alexander Motin mav@FreeBSD.org
Signed-off-by: Ryan Moeller ryan@iXsystems.com
Closes #14291
(cherry picked from commit dc8c2f6)

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

vdev_geom_read_pool_label() can leave NULL in configs.  Check for it
and skip consistently when generating rootconf.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#14291
(cherry picked from commit dc8c2f6)
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 22, 2022
@behlendorf behlendorf merged commit fbbc375 into openzfs:zfs-2.1.8-staging Jan 5, 2023
@ghost ghost deleted the boot-bp branch January 5, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants