Move dmu_buf_rele() after dsl_dataset_sync_done() #14523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaybee
approved these changes
Feb 23, 2023
|
CC @tonyhutter for including this in 2.1.10. |
ahrens
approved these changes
Feb 23, 2023
Otherwise the dataset may be freed after the last dmu_buf_rele() leading to a panic. Signed-off-by: George Amanakis <gamanakis@gmail.com>
13 tasks
gamanakis
added a commit
to gamanakis/zfs
that referenced
this pull request
Feb 27, 2023
Otherwise the dataset may be freed after the last dmu_buf_rele() leading to a panic. Reviewed-by: Mark Maybee <mark.maybee@delphix.com> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Signed-off-by: George Amanakis <gamanakis@gmail.com> Closes openzfs#14522 Closes openzfs#14523
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 3, 2023
Otherwise the dataset may be freed after the last dmu_buf_rele() leading to a panic. Reviewed-by: Mark Maybee <mark.maybee@delphix.com> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Signed-off-by: George Amanakis <gamanakis@gmail.com> Closes openzfs#14522 Closes openzfs#14523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #14522
Description
Move dmu_buf_rele() after dsl_dataset_sync_done(), otherwise the dataset may be freed after the last dmu_buf_rele() leading to a panic.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.