sighandler() should take 2 arguments

[thegreatgazoo]

Stopping arcstat.py with ^C always ends up with error:
TypeError: sighandler() takes no arguments (2 given)

Signed-off-by: Isaac Huang he.huang@intel.com
Issue #2179

[behlendorf]

@aarcane @prakashsurya could you please review these proposed changes.

[prometheanfire]

why is there so much more (the new function and stuff)?

[ryao]

@prometheanfire @thegreatgazoo sent two patches, but made the pull request appear to only have one. I will not comment on the specifics of the code since I am not fluent in python.

[behlendorf]

@prometheanfire It determines the total number of lines in your terminal so that value may be used as the default instead of 20. That makes the behavior consistent with tools like vmstat.

[thegreatgazoo]

@prometheanfire when I was trying to make a pull request for the 2nd commit, it automatically got into this pull request. I'm still new to github so I must have made some mistake.

[prometheanfire]

@thegreatgazoo github tracks the branch you do the pull request from (looks like your master branch). I would create a branch, for each feature you want to submit and then submit a pull request for each branch. In this case one to fix the bug and one to add support for the new function.

[thegreatgazoo]

New pull requests sent: #2182 and #2183

[behlendorf]

@thegreatgazoo Thanks for splitting this up. Just for future reference the only reasons you might want to include multiple patches in a single pull requests are:

1. All the patches are related to a single new feature being added. For example, there is a stack of patches waiting to merged for the new event daemon infrastructure which are all related and in a single pull request.

2. There's a dependency between patches.

[prometheanfire]

also to keep in mind, a patch should be able to be applied atomicly without breaking things.

patch 1 of a 5 part patch series should be able to be applied alone without breaking things (maybe not only patch 2, since there may be a dep on patch 1 from patch 2, but you get the idea I hope).