arcstat.py better print 1 header per screen #2183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now arcstat.py prints one header every hdr_intr (20 by default) lines. It'd be nice if hdr_intr is set according to terminal window size, i.e. one header per screenful of outputs. Signed-off-by: Isaac Huang <he.huang@intel.com> Issue #2181
|
Looks good to me. Although I'm not sure I like the new "one header per screen" behavior. I actually prefer having a header line shown more frequently than once per screen. Would you be opposed to keeping the default behavior the same, but adding an option to use this behavior? Or maybe have this be the default, but add an option to specify the header interval explicitly? |
|
Personally, I prefer only getting one header per screen, it's more consistent with the vmstat behavior under Linux. And along those lines a That said, we can certainly leave controlling the frequency of the header to a follow up patch. I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now arcstat.py prints one header every hdr_intr
(20 by default) lines. It'd be nice if hdr_intr
is set according to terminal window size, i.e.
one header per screenful of outputs.
Signed-off-by: Isaac Huang he.huang@intel.com
Issue #2181