Update descriptions for vnops #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These descriptions are not uptodate with the code. Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8767 +/- ##
==========================================
+ Coverage 78.63% 78.72% +0.08%
==========================================
Files 381 381
Lines 117798 117798
==========================================
+ Hits 92636 92740 +104
+ Misses 25162 25058 -104
Continue to review full report at Codecov.
|
behlendorf
approved these changes
May 24, 2019
ikozhukhov
reviewed
May 24, 2019
| * cr - credentials of caller. | ||
| * flags - case flags | ||
| * | ||
| * OUT: ipp - Inode for new symbolic link. |
There was a problem hiding this comment.
can we add big comment about inode as Linux specific and provide references like (see comment above) about this specific?
ipp - it is inode Linux specific and known only to persons who looked it before.
There was a problem hiding this comment.
Well, I get what you mean, but this entire file is pretty much Linux specific in ZoL, with all the changes to be able to call VOP's from Linux VFS interface.
e.g. zfs_read() in ZoL has
IN: ip - inode of file to be read from.
whereas in FreeBSD
IN: vp - vnode of file to be read from.
so there are at least several comment diffs like this already.
There was a problem hiding this comment.
This is something we'll want to work on once the code can be built on multiple platforms.
ikozhukhov
approved these changes
May 24, 2019
behlendorf
added
Status: Accepted
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 7, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 15, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 13, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 22, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 23, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 17, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes openzfs#8767
tonyhutter
pushed a commit
that referenced
this pull request
Sep 26, 2019
These descriptions are not uptodate with the code. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Closes #8767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update descriptions for vnops.
Description
These descriptions are not uptodate with the code.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.