Skip to content

Commit

Permalink
Update descriptions for vnops
Browse files Browse the repository at this point in the history
These descriptions are not uptodate with the code.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#8767
  • Loading branch information
kusumi authored and tonyhutter committed Aug 22, 2019
1 parent e8ef3b0 commit e93b393
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
20 changes: 11 additions & 9 deletions module/zfs/zfs_vnops.c
Original file line number Diff line number Diff line change
Expand Up @@ -1676,6 +1676,7 @@ zfs_tmpfile(struct inode *dip, vattr_t *vap, int excl,
* IN: dip - inode of directory to remove entry from.
* name - name of entry to remove.
* cr - credentials of caller.
* flags - case flags.
*
* RETURN: 0 if success
* error code if failure
Expand Down Expand Up @@ -1917,6 +1918,7 @@ zfs_remove(struct inode *dip, char *name, cred_t *cr, int flags)
* dirname - name of new directory.
* vap - attributes of new directory.
* cr - credentials of caller.
* flags - case flags.
* vsecp - ACL to be set
*
* OUT: ipp - inode of created directory.
Expand Down Expand Up @@ -2235,13 +2237,12 @@ zfs_rmdir(struct inode *dip, char *name, struct inode *cwd, cred_t *cr,
}

/*
* Read as many directory entries as will fit into the provided
* dirent buffer from the given directory cursor position.
* Read directory entries from the given directory cursor position and emit
* name and position for each entry.
*
* IN: ip - inode of directory to read.
* dirent - buffer for directory entries.
*
* OUT: dirent - filler buffer of directory entries.
* ctx - directory entry context.
* cr - credentials of caller.
*
* RETURN: 0 if success
* error code if failure
Expand Down Expand Up @@ -4006,13 +4007,14 @@ zfs_rename(struct inode *sdip, char *snm, struct inode *tdip, char *tnm,
* Insert the indicated symbolic reference entry into the directory.
*
* IN: dip - Directory to contain new symbolic link.
* link - Name for new symlink entry.
* name - Name of directory entry in dip.
* vap - Attributes of new entry.
* target - Target path of new symlink.
*
* link - Name for new symlink entry.
* cr - credentials of caller.
* flags - case flags
*
* OUT: ipp - Inode for new symbolic link.
*
* RETURN: 0 on success, error code on failure.
*
* Timestamps:
Expand Down Expand Up @@ -4216,6 +4218,7 @@ zfs_readlink(struct inode *ip, uio_t *uio, cred_t *cr)
* sip - inode of new entry.
* name - name of new entry.
* cr - credentials of caller.
* flags - case flags.
*
* RETURN: 0 if success
* error code if failure
Expand Down Expand Up @@ -4729,7 +4732,6 @@ zfs_inactive(struct inode *ip)
* IN: ip - inode seeking within
* ooff - old file offset
* noffp - pointer to new file offset
* ct - caller context
*
* RETURN: 0 if success
* EINVAL if new offset invalid
Expand Down
7 changes: 3 additions & 4 deletions module/zfs/zfs_znode.c
Original file line number Diff line number Diff line change
Expand Up @@ -651,12 +651,11 @@ static zfs_acl_phys_t acl_phys;
* cr - credentials of caller
* flag - flags:
* IS_ROOT_NODE - new object will be root
* IS_TMPFILE - new object is of O_TMPFILE
* IS_XATTR - new object is an attribute
* bonuslen - length of bonus buffer
* setaclp - File/Dir initial ACL
* fuidp - Tracks fuid allocation.
* acl_ids - ACL related attributes
*
* OUT: zpp - allocated znode
* OUT: zpp - allocated znode (set to dzp if IS_ROOT_NODE)
*
*/
void
Expand Down

0 comments on commit e93b393

Please sign in to comment.