Linux 5.3 compat: Makefile subdir-m no longer supported. #9169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa, I just pushed out the same fix (#9170) and then saw this PR. Since you beat me to it, can you incorporate my |
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Signed-off-by: Dominic Pearson <dsp@technoanimal.net>
|
I incorprated the .gitignore changes as requested. I note that some tests failed - I am not convinced my changes had anything to do with it though, and restarting the build may lead to a different result. I don't think I have the ability to do that though, sorry. |
Codecov Report
@@ Coverage Diff @@
## master #9169 +/- ##
==========================================
+ Coverage 79.02% 79.14% +0.12%
==========================================
Files 400 400
Lines 121841 121831 -10
==========================================
+ Hits 96286 96428 +142
+ Misses 25555 25403 -152
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Aug 16, 2019
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 21, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 22, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 23, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 17, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 23, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
tonyhutter
pushed a commit
that referenced
this pull request
Sep 26, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes #9169
snajpa
pushed a commit
to vpsfreecz/zfs
that referenced
this pull request
Oct 19, 2019
Uses obj-m instead, due to kernel changes. See LKML: Masahiro Yamada, Tue, 6 Aug 2019 19:03:23 +0900 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Dominic Pearson <dsp@technoanimal.net> Closes openzfs#9169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses obj-m instead, due to kernel changes.
See LKML: [PATCH 3/3] kbuild: show hint if subdir-y/m is used to visit module Makefile
Motivation and Context
zfs fails to build on linux-5.3
Description
Trivial change to the Makefile.in to replace subdir-m with obj-m as per the LKML thread.
How Has This Been Tested?
"It works on my machine." zfs module successfully builds and loads on 5.3.0-rc4 with these changes.
Types of changes
Checklist:
Signed-off-by.