Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 5.3: Fix switch() fall though compiler errors #9170

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Linux 5.3: Fix switch() fall though compiler errors #9170

merged 1 commit into from
Aug 21, 2019

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented Aug 15, 2019 •
edited
Loading

Motivation and Context

Fix builds

Description

Fix some switch() fall-though compiler errors:

        abd.c:1504:9: error: this statement may fall through

How Has This Been Tested?

Test built and loaded the module on Ubuntu 18.04 with 5.3 kernel.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter tonyhutter mentioned this pull request Aug 15, 2019
Merged
12 tasks
behlendorf
behlendorf requested changes Aug 15, 2019
View reviewed changes
module/lua/llex.c Show resolved Hide resolved
module/zfs/abd.c Outdated Show resolved Hide resolved
module/zfs/vdev_raidz_math_scalar.c Outdated Show resolved Hide resolved
@behlendorf
Copy link
Contributor

@tonyhutter I've gone ahead and merged ff4b68e which contains the subdir-m fix, so please drop those hunks when you next rebase this.

@behlendorf behlendorf added the Status: Work in Progress Not yet ready for general review label Aug 19, 2019
@tonyhutter tonyhutter changed the title Linux 5.3: Add case() breaks, fix subdir-m Linux 5.3: Fix switch() fall though compiler errors Aug 20, 2019
@tonyhutter
Copy link
Contributor Author

@behlendorf I updated the patch with the fixes

@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
54eb42c 
- Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@codecov
Copy link

codecov bot commented Aug 21, 2019 •
edited
Loading

Codecov Report

Merging #9170 into master will decrease coverage by 0.14%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9170      +/-   ##
==========================================
- Coverage   79.31%   79.16%   -0.15%     
==========================================
  Files         400      400              
  Lines      122000   121943      -57     
==========================================
- Hits        96765    96540     -225     
- Misses      25235    25403     +168
Flag Coverage Δ
#kernel 79.69% <33.33%> (-0.17%) ⬇️
#user 67.08% <50%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c759b33...54eb42c. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Work in Progress Not yet ready for general review labels Aug 21, 2019
@behlendorf behlendorf merged commit a9ebdfd into openzfs:master Aug 21, 2019
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
d71eef6 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
94dc400 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
f16952e 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
640013e 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
7326e24 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
00603b9 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
tonyhutter added a commit that referenced this pull request Sep 26, 2019
@tonyhutter
Linux 5.3: Fix switch() fall though compiler errors
023ab67 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #9170
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 19, 2019
@tonyhutter @snajpa
Linux 5.3: Fix switch() fall though compiler errors
9036a32 
Fix some switch() fall-though compiler errors:

    abd.c:1504:9: error: this statement may fall through

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#9170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyhutter @behlendorf