Added command line parameter to not create zim for languages with variants #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavel-karatsiuba thx but:
|
kelson42
requested changes
Mar 4, 2023
| @@ -81,6 +81,9 @@ const fetchLanguages = async (): Promise<void> => { | |||
| rows.forEach((item) => { | |||
| const url = $(item).find('td.list-highlight-background:first-child a').attr('href') | |||
| const slug = /locale=(.*)$/.exec(url)?.pop() | |||
| if (argv.withoutLanguageVariants && slug.includes('_')) { | |||
There was a problem hiding this comment.
We should have a log entry
| @@ -81,6 +81,9 @@ const fetchLanguages = async (): Promise<void> => { | |||
| rows.forEach((item) => { | |||
| const url = $(item).find('td.list-highlight-background:first-child a').attr('href') | |||
| const slug = /locale=(.*)$/.exec(url)?.pop() | |||
| if (argv.withoutLanguageVariants && slug.includes('_')) { | |||
There was a problem hiding this comment.
It should not be based on the slug, but on the lang. This is not robust.
There was a problem hiding this comment.
Slug it just a variable name. It is filled from the locale part of the URL.
All other steps and functions use the value from this variable to define the language.
README.md
Outdated
| @@ -30,6 +30,13 @@ npm i && npm start | |||
| The above will eventually output a ZIM file to ```dist/``` | |||
|
|
|||
| ## Command line arguments | |||
| `--withoutLanguageVariants` uses to exclude languages with County variant. For example `en_ca` will not be present in zim with this argument. | |||
README.md
Outdated
| @@ -30,6 +30,13 @@ npm i && npm start | |||
| The above will eventually output a ZIM file to ```dist/``` | |||
|
|
|||
| ## Command line arguments | |||
| `--withoutLanguageVariants` uses to exclude languages with County variant. For example `en_ca` will not be present in zim with this argument. | |||
There was a problem hiding this comment.
From the phet site, we are getting "en_CA"
| @@ -81,6 +81,9 @@ const fetchLanguages = async (): Promise<void> => { | |||
| rows.forEach((item) => { | |||
| const url = $(item).find('td.list-highlight-background:first-child a').attr('href') | |||
Description typos fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata
Languageis not supporting language with variants, for example, 'en_CA'.With this PR added the command line parameter
--withoutLanguageVariantswhich filters the language list and removes languages with variants.This means that if the user uses the parameter
--withoutLanguageVariantsthen zim files for languages with variants will not be created.Fix: #204