Skip to content

Fix remaining code qa and typing issues resulting in breaking changes #131

Closed
@benoit74

Description

@benoit74

#128 has shown that there is some code qa / typing issues that have to be fixed but will ultimately lead to a breaking change in term of API, hence needing a major release.

  • fix all FBT001 / FTB002
  • fix N813, N818
  • rename getLogger to get_logger
  • decide about N803 issues in config_metadata of zim/creator.py (this has been made intentionally to match the real tag name)
  • fix many typing issues:
    • the ones associated with RUF013
    • the ones around metadata validation
    • other issues should be investigated as well

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions