-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos, remaining code qa and typing issues resulting in breaking changes #178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1452 1475 +23
Branches 251 256 +5
=========================================
+ Hits 1452 1475 +23 ☔ View full report in Codecov by Sentry. |
ff5ce7d
to
90d3eac
Compare
90d3eac
to
63bc653
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I only have a few questions and suggestions but it's already OK IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…rsion` to fix typo and fix type hints
… convert_and_check_metadata
75eed4e
to
2d2c547
Compare
Fix #131
It's time for this big overhaul of the codebase, it was too complex to include SVG support without proper typing in the "image" module.
Some remarks:
IO[bytes]
instead ofio.BytesIO
when possible since it is more genericgetLogger
namecreator.config_indexing
to match argument orders of the libzim creatorvideo.encoding.reencode
, I just fixed to return type since it was way more straightforward, including in term of usage. Returningtuple[bool, subprocess.CompletedProcess[str]] | bool
seems preferable for the type checker rather thantuple[bool, subprocess.CompletedProcess[str] | None]
(it looks like type checker prefer clearly to have two potentials real types rather than optionals)