Create correct redirection when dumping zim with old namespace scheme. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With old namespace scheme, `Item::getPath()` contains the namespace, so we must compute the relative path. Surprisingly, it is already done for httpRedirect. Let's do it all the time. Fix #303
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 51.13% 51.13%
=======================================
Files 21 21
Lines 1942 1942
Branches 1154 1151 -3
=======================================
Hits 993 993
Misses 947 947
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With old namespace scheme,
Item::getPath()contains the namespace,so we must compute the relative path.
Surprisingly, it is already done for httpRedirect. Let's do it all the
time.
Fix #303