fix: rewrite illustration check to not use regex #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
changed the title
veloman-yunkan
requested changes
Jul 9, 2023
|
|
||
| const std::string& illustration = data["Illustration_48x48@1"]; | ||
|
|
||
| if (illustration.length() >= 24) { |
There was a problem hiding this comment.
Why is this test needed? What's wrong with always (unconditionally) testing the first 8 bytes?
| // In PNG file, 16-20 is width and 20-24 is height in big endian order. | ||
| const std::string png48x48 = {0x00, 0x00, 0x00, 0x30, 0x00, 0x00, 0x00, 0x30}; | ||
|
|
||
| if (illustration.substr(16, 8) != png48x48) { |
There was a problem hiding this comment.
illustration.substr(16, 8) will throw if illustration.length() < 16
|
@shenlebantongying Any news? |
|
@mgautierfr Can you please fix PR |
|
After #369 has been merged this should be rebased and readapted to benefit from the illustration size check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #352 by not using regex on binary data.