Use search regex instead of match for metadata check. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 27.72% 27.72%
=======================================
Files 26 26
Lines 2528 2528
Branches 1349 1349
=======================================
Hits 701 701
Misses 1346 1346
Partials 481 481
☔ View full report in Codecov by Sentry. |
veloman-yunkan
requested changes
Sep 3, 2023
Fix #345, #352 Investigating #345, it seems that zimcheck-test is getting a segfault (when run with qemu-aarch64) in `std::regex_match` and the PNG_REGEXP_DATA. It appears the segfault happens with a huge callstack. I don't know where the bug is exactly (qemu ? std ?) but the behavior is the same than #352. By using `regex_search` we allow the regex to not match the whole content (but still allow it if the regex ends with `$`) As we don't need to check all the PNG data, and check only the beginning, `regex_search` is passing without segfault (early exit ?)
mgautierfr
force-pushed
the
fix_aarch64_test
branch
from
edfe3f6
to
b0a2e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #345
Fix #352
Investigating #345, it seems that zimcheck-test is getting a segfault (when run with qemu-aarch64) in
std::regex_matchand the PNG_REGEXP_DATA. It appears the segfault happens with a huge callstack. I don't know where the bug is exactly (qemu ? std ?) but the behavior is the same than #352.By using
regex_searchwe allow the regex to not match the whole content (but still allow it if the regex ends with$)As we don't need to check all the PNG data, and check only the beginning,
regex_searchis passing without segfault (early exit ?)This PR take another approach than #358 by fixing the regex instead of avoiding it (but it doesn't check for the size)
(To be honest, I've made this fix before realizing that it was fixing the same bug than #352)