Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapperParsingException on elasticsearch when address annotation present #1239

Closed
codefromthecrypt opened this issue Aug 16, 2016 · 2 comments

Comments

@codefromthecrypt
Copy link
Member

"sa" and "ca" binary annotations are of type boolean, not string. We should make sure we only index string ones, if possible.

[Titania] failed to execute [index {[zipkin-2016-08-16][span][AVaRHcergLmKHNBk-IeX], source[{"timestamp_millis":1471313463199,"traceId":"7a00d01b5b3abafe","name":"get","id":"7d8e079b9a44cd82","parentId":"7a00d01b5b3abafe","timestamp":1471313463199000,"duration":3000,"annotations":[{"timestamp":1471313463199000,"value":"cs","endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1"}},{"timestamp":1471313463199000,"value":"ws","endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1"}},{"timestamp":1471313463201000,"value":"wr","endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1"}},{"timestamp":1471313463202000,"value":"cr","endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1"}}],"binaryAnnotations":[{"key":"ca","value":true,"endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1","port":63005}},{"key":"clnt/finagle.version","value":"6.36.0","endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1"}},{"key":"http.uri","value":"/api","endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1"}},{"key":"sa","value":true,"endpoint":{"serviceName":"frontend","ipv4":"127.0.0.1","port":9000}}]}]}] on [[zipkin-2016-08-16][1]]
MapperParsingException[failed to parse]; nested: IllegalArgumentException[mapper [binaryAnnotations.value] of different type, current_type [boolean], merged_type [string]];
@codefromthecrypt
Copy link
Member Author

note: this is easy to reproduce if you use JMH or similar to pummel the elasticsearch server :)

@codefromthecrypt
Copy link
Member Author

seems related elastic/elasticsearch#12366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant