Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skips indexing of non-string binary annotations in Elasticsearch #1286

Merged
merged 1 commit into from
Sep 10, 2016
Merged

Skips indexing of non-string binary annotations in Elasticsearch #1286

merged 1 commit into from
Sep 10, 2016

Conversation

codefromthecrypt
Copy link
Member

Fixes #1239

@codefromthecrypt
Copy link
Member Author

cc @anuraaga I think this is squashed.. hitting a fresh ES host tons of times per second recreates the problem, and I can't repro it anymore now :)

The root issue was a race condition of who indexed first, a boolean or string value binary annotation.

@anuraaga
Copy link
Contributor

LGTM thanks!

@codefromthecrypt codefromthecrypt merged commit e0503d9 into master Sep 10, 2016
@codefromthecrypt codefromthecrypt deleted the no-more-errors branch September 10, 2016 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codefromthecrypt @anuraaga