Placeholder for geocoded radiometric calibration parameters #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongsujeong
commented
Mar 17, 2023
src/compass/s1_geocode_slc.py
Outdated
| @@ -195,6 +196,95 @@ def run(cfg: GeoRunConfig): | |||
| weather_model_path=cfg.weather_model_file, | |||
| delay_type=cfg.tropo_params.delay_type) | |||
|
|
|||
| # Designate radiometric calibration parameter to geocode | |||
| calibration_dict = { | |||
| 'gamma':burst.burst_calibration.gamma, | |||
There was a problem hiding this comment.
Please note that beta_naught is not provided here because it is constant, and was already provided in /science/SENTINEL1/CSLC/corrections/calibration
LiangJYu
reviewed
Mar 17, 2023
…geocode_metadata.py`
LiangJYu
reviewed
Mar 21, 2023
LiangJYu
reviewed
Mar 21, 2023
|
Also, what about the datasets in the noise group? Do they need to be moved as well in the placeholder group? |
Co-authored-by: Liang Yu <liangjyu@gmail.com>
Co-authored-by: Liang Yu <liangjyu@gmail.com>
Co-authored-by: Liang Yu <liangjyu@gmail.com>
Co-authored-by: Liang Yu <liangjyu@gmail.com>
…PASS into calibration_information
… removed irrelevant calibration info in geogrid.
LiangJYu
reviewed
Mar 21, 2023
vbrancat
approved these changes
Mar 21, 2023
Co-authored-by: Liang Yu <liangjyu@gmail.com>
seongsujeong
added a commit
to seongsujeong/COMPASS
that referenced
this pull request
Mar 31, 2023
…t#114) * Placeholder for geocoded radiometric calibration parameters * geocoded calibration parameter feature as standalone function in `s1_geocode_metadata.py` * Update src/compass/s1_geocode_metadata.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_metadata.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/compass/s1_geocode_metadata.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * Apply suggestions from code review by @LiangJYu Co-authored-by: Liang Yu <liangjyu@gmail.com> * finalizing applying the code change suggestion * removed unused imports * geocode calibration LUTS only when it is available in burst object * Moving all calibration info. into `metadata/calibration_information`; removed irrelevant calibration info in geogrid. * `dn` added for geocoded LUT; note added for placeholder * removed unused codes * addressing codacy issue * Update src/compass/s1_geocode_metadata.py Co-authored-by: Liang Yu <liangjyu@gmail.com> --------- Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a placeholders for geocoded LUTs for radiometric calibration.
gammaandsigma_naughtare geocoded and placed into the group/science/SENTINEL1/CSLC/metadata/calibration_informationas shown in the screenshot below.