Placeholder for geocoded noise LUT #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrancat
reviewed
Mar 22, 2023
src/compass/s1_geocode_metadata.py
Outdated
|
|
||
| # define the geogrid for calbration LUT | ||
| noise_radargrid = radar_grid.multilook(dec_factor, | ||
| dec_factor) |
src/compass/s1_geocode_metadata.py
Outdated
| iters = cfg.geo2rdr_params.numiter | ||
| scratch_path = out_paths.scratch_directory | ||
|
|
||
| # Designate radiometric calibration parameter to geocode |
There was a problem hiding this comment.
I think this might be a copy & paste error
| @@ -258,6 +258,133 @@ def geocode_calibration_luts(geo_burst_h5, burst, cfg, | |||
| del geocoded_cal_lut_raster | |||
|
|
|||
|
|
|||
|
|
|||
| def geocode_noise_luts(geo_burst_h5, burst, cfg, | |||
There was a problem hiding this comment.
This function has a lot of code repetition with the calibration LUT function. I am wondering whether is possible to consolidate the two in a single function
There was a problem hiding this comment.
I agree with your concern. The code redundancy has reduced thanks to @LiangJYu.
LiangJYu
approved these changes
Mar 22, 2023
Co-authored-by: Liang Yu <liangjyu@gmail.com>
vbrancat
approved these changes
Mar 22, 2023
seongsujeong
added a commit
to seongsujeong/COMPASS
that referenced
this pull request
Mar 31, 2023
* noise info moved to `metadata/noise_information` * `geocode_noise_luts` implemented * removed radargrid-based information in `noise_information` * codacy issue * reduce duplicate code * fix on `lut_path` definition * Apply suggestions from code review Co-authored-by: Liang Yu <liangjyu@gmail.com> --------- Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the geocoded noise LUT into the metadata. Currently the noise information is included in the product as radargrid. It is necessary to provide the geocoded LUT, rather than radargrid LUT, to make this information useful.
This addition is basically the repetition of #114 (geocoded calibration LUT), also modification of the noise information's location.