Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: namespace role/rolebinding deletion problem #1890

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented May 5, 2023

No description provided.

@csviri csviri self-assigned this May 5, 2023
@csviri
Copy link
Collaborator Author

csviri commented May 5, 2023

Just a test to reproduce the issue.

@csviri
Copy link
Collaborator Author

csviri commented May 5, 2023

Actually will convert it to an e2e test, since this would be much nicer with an e2e test.

@csviri csviri changed the title feat: namespace deletion issue feat: namespace role/rolebinding deletion problem May 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

84.1% 84.1% Coverage
0.0% 0.0% Duplication

@csviri csviri force-pushed the next branch 3 times, most recently from 2a0a4bf to da83233 Compare May 31, 2023 07:40
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023
@csviri csviri force-pushed the next branch 2 times, most recently from c84c3e3 to 1042fc5 Compare June 21, 2023 14:01
Base automatically changed from next to main June 23, 2023 15:42
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2023
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 23, 2023
@csviri csviri removed the stale label Aug 23, 2023
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 23, 2023
@csviri csviri removed the stale label Oct 23, 2023
@csviri csviri force-pushed the role-deletion-handling-controllers branch from f3c558d to 9da1806 Compare December 12, 2023 12:47
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace deletion stuck if contains CRs that are watched by the operator
2 participants