-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial flaky test mitigation #2625
Initial flaky test mitigation #2625
Conversation
c75a68b
to
c78626f
Compare
/hold |
c78626f
to
e8a4922
Compare
Reference: Using label decorators in Ginkgo 2.0 |
/lgtm |
e8a4922
to
2d49fb5
Compare
/lgtm |
2d49fb5
to
92f56ed
Compare
ed3e5c8
to
c90ccd8
Compare
/lgtm |
@perdasilva Looks like the tests are generating invalid label values ATM:
|
faf4272
to
566856c
Compare
/lgtm |
94a1c0e
to
f45fc36
Compare
/lgtm |
f45fc36
to
80e95f1
Compare
New changes are detected. LGTM label has been removed. |
Looks like the filtering isn't working as intended?
/hold |
80e95f1
to
b01020e
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: perdasilva <perdasilva@redhat.com> Signed-off-by: perdasilva <perdasilva@redhat.com>
b01020e
to
336fe33
Compare
New changes are detected. LGTM label has been removed. |
Description of the change:
This PR makes the following changes and resolved aspects of #2589:
Note
With Ginkgo v2.0 we can actually label tests, which might make this system less brittle. I just don't know what the upfront work required would be to make the upgrade. So, let's use this as a stop gap solution until we migrate and it should be easy enough to then migrate the flaky tests to use labels instead.
Motivation for the change:
Merging PRs is a PITA atm because of flakes. This gives us a way to mark flakes and remove them from the critical path while they get fixed
Reviewer Checklist
/doc
Targets aspects of #2589