Remove CatalogSourceLister usage from resolver/cache. #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
timflannagan
approved these changes
Feb 16, 2022
|
Ah, it looks like approval-acts-as-lgtm doesn't work on this repository. /lgtm |
timflannagan
force-pushed
the
remove-cache-catsrclister
branch
from
b4874f0
to
0ed9044
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Let's get #2625 merged first. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
The cache hardcodes the use of a CatalogSourceLister (imported from a non-resolver package in the OLM module) in order to assign source priorities based on the spec.priority field of CatalogSource. Not all cache sources map to a CatalogSource, so this can instead accept a priority provider interface and the resolver -> non-resolver imports can be removed. Signed-off-by: Ben Luddy <bluddy@redhat.com>
benluddy
force-pushed
the
remove-cache-catsrclister
branch
from
0ed9044
to
48984bd
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache hardcodes the use of a CatalogSourceLister (imported from a
non-resolver package in the OLM module) in order to assign source
priorities based on the spec.priority field of CatalogSource. Not all
cache sources map to a CatalogSource, so this can instead accept a
priority provider interface and the resolver -> non-resolver imports
can be removed.