Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update o-f/api dependency to v0.17 #2848

Merged
merged 1 commit into from
Aug 31, 2022
Merged

chore: update o-f/api dependency to v0.17 #2848

merged 1 commit into from
Aug 31, 2022

Conversation

tylerslaton
Copy link
Contributor

Description of the change:
Updating o-f/api dependency to v0.17.

Motivation for the change:
To include spec.runAsRoot field for PSA work.

Architectural changes:
N/A

Testing remarks:
N/A

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

chore: update o-f/api dependency to v0.17
c2179b9 
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
anik120
anik120 reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @tylerslaton!! 🚀

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit bd97e32 into operator-framework:master Aug 31, 2022
@anik120
Copy link
Contributor

anik120 commented Aug 31, 2022

Oops, I thought I put a hold on this PR till we resolved a new feedback. operator-framework/api#259 has the changes, once that merges I plan on creating a new api v0.17.0 release, so reverting this PR so that we don't have to release a v0.18.0 of api. Sorry about the confusion folks

anik120 added a commit that referenced this pull request Aug 31, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (#2848)"
6d7a1e3 
This reverts commit bd97e32.
@anik120 anik120 mentioned this pull request Aug 31, 2022
Closed
anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Aug 31, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (operator-framework…
4413599 
…#2848)"

This reverts commit bd97e32.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
openshift-merge-robot pushed a commit that referenced this pull request Aug 31, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2853)
ff23e22 
This reverts commit bd97e32.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Sep 13, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (operator-framework…
0daa362 
…#2848)"

This reverts commit bd97e32.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Sep 13, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (operator-framework…
108e1ae 
…#2848)"

This reverts commit bd97e32.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting operator-framework#2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
@anik120 anik120 mentioned this pull request Sep 13, 2022
Merged
11 tasks
openshift-merge-robot pushed a commit that referenced this pull request Sep 13, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
bfeb1e4 
This reverts commit bd97e32.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Oct 24, 2022
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
0d36dce 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: perdasilva
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Oct 24, 2022
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
c524345 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: perdasilva
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2023
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
87e0265 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2023
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
cbf6a8f 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Mar 15, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
0b624b4 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Mar 28, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
e963abd 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
17d809e 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
cc5fcb3 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
0e821b4 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 anik120 left review comments

@njhale njhale Awaiting requested review from njhale

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

@anik120 anik120

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylerslaton @grokspawn @anik120 @openshift-merge-robot