Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: update o-f/api dependency to v0.17" #2852

Closed
wants to merge 1 commit into from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Aug 31, 2022

Reverts #2848

operator-framework/api#259 has new feedback about a change in the current v0.17.0 release. Planning on republishing api v0.17.0 once that PR merges, so reverting this for now.

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anik120
Once this PR has been reviewed and has the lgtm label, please assign dinhxuanvu for approval by writing /assign @dinhxuanvu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tylerslaton
Copy link
Contributor

We need to add a signature to the commit.

/hold
/lgtm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@anik120
Copy link
Contributor Author

anik120 commented Aug 31, 2022

@tylerslaton opened #2853 that has the signature coz I couldn't edit the commit on this one created with the UI 😢

@anik120 anik120 closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants