containerdregistry: support per-repo credentials #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
joelanford
force-pushed
the
per-repo-auth
branch
from
902db98 to
7206900
Compare
openshift-merge-robot
removed
the
needs-rebase
joelanford
commented
Nov 13, 2023
| @@ -8,14 +8,14 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| "github.com/spf13/cobra" | |||
| "google.golang.org/grpc" | |||
| health "google.golang.org/grpc/health/grpc_health_v1" | |||
There was a problem hiding this comment.
We had a copy of this package in our repo, and some dependencies pulled in from this commit caused a namespace conflict because two different packages defined the same GRPC protobuf names: our copy, and this official package.
To resolve, I deleted our package and switched everything to the official package.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
=======================================
Coverage 53.32% 53.32%
=======================================
Files 108 108
Lines 10337 10337
=======================================
Hits 5512 5512
Misses 3841 3841
Partials 984 984 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
per-repo-auth
branch
from
c39b878 to
3f92a5c
Compare
stevekuznetsov
approved these changes
Nov 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
tonyskapunk
added a commit
to redhatci/ansible-collection-redhatci-ocp
that referenced
this pull request
Jan 4, 2024
The opm-auths is a wrapper script provided by dci-openshift-agent that brings support for multi-entry registry authentication when using opm. The opm client lacked the functionality as reported in: operator-framework/operator-registry#935 But lately it was added in: operator-framework/operator-registry#1165 Now it is available in the stable ocp clients: https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/
3 tasks
tonyskapunk
added a commit
to redhatci/ansible-collection-redhatci-ocp
that referenced
this pull request
Jul 30, 2024
The opm-auths is a wrapper script provided by dci-openshift-agent that brings support for multi-entry registry authentication when using opm. The opm client lacked the functionality as reported in: operator-framework/operator-registry#935 But lately it was added in: operator-framework/operator-registry#1165 Now it is available in the stable ocp clients: https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/
sf-project-io
pushed a commit
to redhat-cip/dci-openshift-agent
that referenced
this pull request
Aug 9, 2024
The opm-auths is a wrapper script that brings support for multi-entry registry authentication when using opm. The opm client lacked the functionality as reported in: operator-framework/operator-registry#935 But lately it was added in: operator-framework/operator-registry#1165 And now it is available in the stable ocp clients https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/ Thus, the wrapper is not needed any longer. Lastly, opm stable now provides two FIPS compiant binaries. ONe for rhel8 and another for rhel9, downloading the correct one for the agent. Change-Id: Idab1a56a594a2f5c1e6a623af8d6d9b7ff359cb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Updates the containerdregistry implementation (e.g. used by
opm renderand thenonecontainer tool) to support:containers/auth.jsonfile formatREGISTRY_AUTH_FILEandDOCKER_CONFIGenvironment variables.Motivation for the change:
Closes #935
Closes #919
Closes #1114
Reviewer Checklist
/docs