Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of wrapper script opm-auths #116

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Remove the use of wrapper script opm-auths #116

merged 4 commits into from
Aug 9, 2024

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Jan 4, 2024 •
edited
Loading

The opm-auths is a wrapper script provided by dci-openshift-agent that brings support for multi-entry registry authentication when using opm.

The opm client lacked the functionality as reported in: operator-framework/operator-registry#935

But lately it was added in:
operator-framework/operator-registry#1165

Now it is not yet coming in the candidate and soon will be available in the stable ocp clients:
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/

Build-depends: https://softwarefactory-project.io/r/c/dci-openshift-agent/+/30506
Build-depends: https://softwarefactory-project.io/r/c/dci-openshift-app-agent/+/32118

Test-Hints: no-check

@tonyskapunk tonyskapunk requested a review from a team as a code owner January 4, 2024 20:16
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/7307d3c3fbae4c91a8f628fac6e22601

✔️ dci-rpm-build-el8 SUCCESS in 3m 33s
✔️ dci-rpm-build-el9 SUCCESS in 3m 15s

pierreblanc
pierreblanc previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@pierreblanc pierreblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Tony ! Thx.
LVGTM

@dcibot
Copy link
Collaborator

dcibot commented Jan 4, 2024

@tonyskapunk tonyskapunk marked this pull request as draft January 4, 2024 22:05
@tonyskapunk
Copy link
Contributor Author

My initial test was incorrect and the stable version of opm (through OCP) does not matches yet the latest upstream version where the support to multiple-entry registries is implemented yet. Moved to draft for the time being.

@fredericlepied fredericlepied force-pushed the main branch 14 times, most recently from 7e6a9fb to d89f6ab Compare January 7, 2024 21:50
@tonyskapunk tonyskapunk self-assigned this Jun 14, 2024
@tonyskapunk
Remove the use of wrapper script opm-auths
c2d8b1c 
The opm-auths is a wrapper script provided by dci-openshift-agent
that brings support for multi-entry registry authentication when
using opm.

The opm client lacked the functionality as reported in:
operator-framework/operator-registry#935

But lately it was added in:
operator-framework/operator-registry#1165

Now it is available in the stable ocp clients:
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/
@tonyskapunk
Retrieve the expected opm client
87b4a16 
Depending on the host, retrieve the right FIPS compliant opm client
@tonyskapunk tonyskapunk force-pushed the opm_stable_multiauth branch from e715970 to 87b4a16 Compare July 30, 2024 21:33
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/14d007ea826945a799361f0b7f468e41

✔️ dci-rpm-build-el8 SUCCESS in 4m 20s
✔️ dci-rpm-build-el9 SUCCESS in 3m 15s

@dcibot
Copy link
Collaborator

dcibot commented Jul 30, 2024

from change #116:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c750b5cbe8f942abaa69f952699bd102

✔️ dci-rpm-build-el8 SUCCESS in 4m 33s
✔️ dci-rpm-build-el9 SUCCESS in 3m 21s

@dcibot
Copy link
Collaborator

dcibot commented Jul 30, 2024

from change #116:

@tonyskapunk
Retrieve the right stable opm client
4e71316 
Depending on the host, retrieve the right FIPS compliant opm client
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/64590ad141e6490d8e602a79de1dfd9c

✔️ dci-rpm-build-el8 SUCCESS in 4m 22s
✔️ dci-rpm-build-el9 SUCCESS in 3m 21s

@dcibot
Copy link
Collaborator

dcibot commented Aug 1, 2024

from change #116:

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Aug 7, 2024

from change #116:

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Aug 8, 2024

from change #116:

@tonyskapunk tonyskapunk marked this pull request as ready for review August 8, 2024 14:05
manurodriguez
manurodriguez approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@manurodriguez manurodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyskapunk tonyskapunk added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 4af8482 Aug 9, 2024
7 checks passed
@tonyskapunk tonyskapunk deleted the opm_stable_multiauth branch August 9, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manurodriguez manurodriguez manurodriguez approved these changes

@pierreblanc pierreblanc pierreblanc left review comments

Assignees

@tonyskapunk tonyskapunk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyskapunk @dcibot @manurodriguez @pierreblanc