Merge pull request #17237 from opf/chore/render-short-in-value-selection

[chore] render item shorts in value selector
opf · Nov 20, 2024 · 3c22b56 · 3c22b56
2 parents 2d0c7fd + ce1500c
commit 3c22b56
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/api/v3/custom_fields/hierarchy/hierarchy_item_representer.rb b/lib/api/v3/custom_fields/hierarchy/hierarchy_item_representer.rb
@@ -36,7 +36,13 @@ def _type
           end
 
           self_link path: :custom_field_item,
-                    title_getter: ->(*) { represented.label }
+                    title_getter: ->(*) do
+                      if represented.short.nil?
+                        represented.label
+                      else
+                        "#{represented.label} (#{represented.short})"
+                      end
+                    end
 
           property :id
 

diff --git a/spec/lib/api/v3/custom_fields/hierarchy/hierarchy_item_representer_rendering_spec.rb b/spec/lib/api/v3/custom_fields/hierarchy/hierarchy_item_representer_rendering_spec.rb
@@ -121,7 +121,7 @@
       it_behaves_like "has a titled link" do
         let(:link) { "self" }
         let(:href) { api_v3_paths.custom_field_item(item.id) }
-        let(:title) { item.label }
+        let(:title) { "#{item.label} (#{item.short})" }
       end
 
       it_behaves_like "has a titled link" do
@@ -171,7 +171,7 @@
       it_behaves_like "has a titled link" do
         let(:link) { "self" }
         let(:href) { api_v3_paths.custom_field_item(item.id) }
-        let(:title) { item.label }
+        let(:title) { "#{item.label} (#{item.short})" }
       end
 
       it_behaves_like "has a titled link" do