Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] render item shorts in value selector #17237

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[chore] render item shorts in value selector #17237

merged 1 commit into from
Nov 20, 2024

Conversation

Kharonus
Copy link
Member

What are you trying to accomplish?

  • the hierarchy item value selector does not render shorts yet, but we want them

Screenshots

image

What approach did you choose and why?

  • the select component renders HalResource arrays
  • the rendered string is, what a resource answers on .name
  • the hierarchy items do not have a name, so they fall back to self_link.title
  • this PR adds the short to the self link title

@Kharonus Kharonus requested a review from a team November 20, 2024 13:42
@Kharonus Kharonus self-assigned this Nov 20, 2024
brunopagno
brunopagno approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@Kharonus Kharonus merged commit 3c22b56 into dev Nov 20, 2024
8 of 9 checks passed
@Kharonus Kharonus deleted the chore/render-short-in-value-selection branch November 20, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunopagno brunopagno brunopagno approved these changes

Assignees

@Kharonus Kharonus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kharonus @brunopagno