-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release/15.0 into dev #17251
Merged
Merged
Merge release/15.0 into dev #17251
+428
−251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk packages with over 100 comments https://community.openproject.org/work_packages/59280
- https://community.openproject.org/wp/59391 - files tab counter now only calls for file links of wp with page size 0 - file links endpoint returns paginated collections - frontend requests file links with page size -1 (INFINITE) - file sync is still executed for ALL file links of a work package, not only the requested page - this is practically no change for the product, as we do not fetch single pages - but fetching only the total numbers with page size 0 now does not trigger a sync
- avoid sql injection - file link collection is returned ordered by id asc
…further rendering optimizations
…he-new-activity-tab-renders-quickly-also-for-work-packages-with-over-100-comments
… will be fully cleaned up in other PR
…he-new-activity-tab-renders-quickly-also-for-work-packages-with-over-100-comments
Co-authored-by: Kabiru Mwenja <k.mwenja@openproject.com>
…be done in the feature flag removal PR
…g-in-files-tab-wp-full-view [#59391] rework file links to paginated collection
…-the-new-activity-tab-renders-quickly-also-for-work-packages-with-over-100-comments Code maintenance/59280 ensure that the new activity tab renders quickly also for work packages with over 100 comments
openprojectci
added
the
create-merge-release-into-dev-pr
Mark auto created PRs that will be auto closed too
label
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by GitHub action