Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat virtio blk support #234

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Feat virtio blk support #234

merged 5 commits into from
Aug 29, 2023

Conversation

artek-koltun
Copy link
Collaborator

Update of opi-spdk-bridge is required

@artek-koltun artek-koltun requested a review from intelfisz August 25, 2023 07:50
glimchb
glimchb reviewed Aug 28, 2023
View reviewed changes
pkg/models/spdk.go Outdated Show resolved Hide resolved
@artek-koltun artek-koltun force-pushed the feat-virtio-blk-support branch from 141b621 to 3fd7a2e Compare August 28, 2023 14:58
@artek-koltun artek-koltun mentioned this pull request Aug 28, 2023
Closed
@artek-koltun artek-koltun marked this pull request as ready for review August 28, 2023 15:03
@artek-koltun artek-koltun requested a review from a team as a code owner August 28, 2023 15:03
glimchb
glimchb approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artek-koltun
chore: update opi-spdk-bridge
161ca96 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
feat(frontend): enable virtio-blk support
f14c62e 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
test(frontend): virtio-blk spdk parameters
9eea5a7 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
docs(virtio-blk): add virtio-blk related cmds
3fd7a2e 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Aug 28, 2023
@artek-koltun artek-koltun mentioned this pull request Aug 29, 2023
Closed
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #234 (d24b445) into main (09d6aee) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   97.84%   98.02%   +0.17%     
==========================================
  Files           4        5       +1     
  Lines         372      405      +33     
==========================================
+ Hits          364      397      +33     
  Misses          7        7              
  Partials        1        1
Files Changed Coverage Δ
pkg/frontend/blk.go 100.00% <100.00%> (ø)
pkg/frontend/frontend.go 100.00% <100.00%> (ø)

@artek-koltun
docs(changelog): virtio-blk support
d24b445 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@intelfisz intelfisz merged commit 5fb03cc into opiproject:main Aug 29, 2023
@artek-koltun artek-koltun mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

@intelfisz intelfisz intelfisz approved these changes

Assignees
No one assigned
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artek-koltun @glimchb @intelfisz