Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: SubsystemListener to NvmeTransport #666

Merged
merged 3 commits into from
Sep 25, 2023
Merged

refact: SubsystemListener to NvmeTransport #666

merged 3 commits into from
Sep 25, 2023

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun
refactor: rename SybsystemListener to NvmeTransport
33e76c9 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
refactor: add returned error to NvmeTransport
96dcc51 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
test: testing NvmeTransports
191bfe5 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #666 (191bfe5) into main (3751e76) will increase coverage by 0.65%.
Report is 28 commits behind head on main.
The diff coverage is 97.22%.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   76.74%   77.40%   +0.65%     
==========================================
  Files          22       32      +10     
  Lines        3638     3828     +190     
==========================================
+ Hits         2792     2963     +171     
- Misses        776      795      +19     
  Partials       70       70
Files Changed Coverage Δ
pkg/frontend/nvme_controller.go 87.61% <93.75%> (-1.77%) ⬇️
pkg/frontend/frontend.go 100.00% <100.00%> (ø)
pkg/kvm/nvme.go 93.10% <100.00%> (+0.45%) ⬆️

... and 19 files with indirect coverage changes

@artek-koltun artek-koltun marked this pull request as ready for review September 25, 2023 08:19
@artek-koltun artek-koltun requested a review from a team as a code owner September 25, 2023 08:19
glimchb
glimchb approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great

@glimchb glimchb merged commit 7eedb99 into opiproject:main Sep 25, 2023
@artek-koltun artek-koltun mentioned this pull request Oct 6, 2023
Closed
@artek-koltun artek-koltun deleted the refactor-rename-subsystem-listener-to-nvme-transport branch November 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb