Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fixed #4791 : Dark Mode the white corners of Stories Cards <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [ ] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only ### Stories Cards corners <img src="https://user-images.githubusercontent.com/76530270/213464300-0d5c18b2-0a8b-4e08-b96b-52c68ce97325.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213464215-2f7de45d-14ef-47ae-a490-e3120f5f0e4a.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213464821-e2d733a2-deed-4dd0-a6d1-85c41942a058.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213464703-97c30e6c-4587-4fe2-85ee-4ed749577b93.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213465037-71f02778-f74e-4211-bea5-e0905a9cf62a.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213465137-aa020700-78e1-40f0-b6a4-e991f9ea2bc7.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213465432-f52e47fe-319a-49ac-bd9c-b2130f329db2.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/213465300-df7196ce-296f-4a88-b818-0a87521ce2c7.png" height="400" style="max-width: 100%"> <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
- Loading branch information