Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Dark Mode the white corners of Stories Cards are visible. #4791

Closed
MohitGupta121 opened this issue Dec 18, 2022 · 2 comments · Fixed by #4847
Closed

In Dark Mode the white corners of Stories Cards are visible. #4791

MohitGupta121 opened this issue Dec 18, 2022 · 2 comments · Fixed by #4847
Assignees
@MohitGupta121

Comments

@MohitGupta121
Copy link
Member

MohitGupta121 commented Dec 18, 2022 •
edited
Loading

In dark mode if you notice closely at the edges, you will see that there are white corners which are visible. They should not be visible.

For example in prmoted_story_card this is happening because we are using app:roundedRectDrawableWithColor="@{viewModel.promotedStory.lessonThumbnail.backgroundColorRgb}"
So basically to fix this in promoted_story_card, we first need to remove app:roundedRectDrawableWithColor="@{viewModel.promotedStory.lessonThumbnail.backgroundColorRgb}" and then in PromotedStoryCardView we should add app:cardBackgroundColor="@android:color/transparent" which should give correct results in both dark mode and light mode.

This above solution is for promoted_story_card only but we have various other cards too like topics, ongoing_topic, completed_story, etc so please focus on them too.

To reproduce
Once logged in, Switch to Dark Mode, and notice the various Story/Topics Cards Corners.
@MohitGupta121 MohitGupta121 self-assigned this Dec 18, 2022
@PratyushSingh07
Copy link

hey @bladebunny @MohitGupta121 @sierisimo @yurilev can i work on this issue?

@MohitGupta121
Copy link
Member Author

@PratyushSingh07 great to see your interest to contribute in oppia. Actually this issue is a part of dark-mode-project and I'm already working on this.
You feel free to pick another issue .

@MohitGupta121 MohitGupta121 mentioned this issue Jan 19, 2023
Merged
6 tasks
rt4914 pushed a commit that referenced this issue Jan 25, 2023
@MohitGupta121
Fixed #4791 : Dark Mode the white corners of Stories Cards (#4847)
21dd212 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

 Fixed #4791 :  Dark Mode the white corners of Stories Cards


<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

### Stories Cards corners

<img
src="https://user-images.githubusercontent.com/76530270/213464300-0d5c18b2-0a8b-4e08-b96b-52c68ce97325.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/213464215-2f7de45d-14ef-47ae-a490-e3120f5f0e4a.png"
height="400" style="max-width: 100%">

<img
src="https://user-images.githubusercontent.com/76530270/213464821-e2d733a2-deed-4dd0-a6d1-85c41942a058.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/213464703-97c30e6c-4587-4fe2-85ee-4ed749577b93.png"
height="400" style="max-width: 100%">

<img
src="https://user-images.githubusercontent.com/76530270/213465037-71f02778-f74e-4211-bea5-e0905a9cf62a.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/213465137-aa020700-78e1-40f0-b6a4-e991f9ea2bc7.png"
height="400" style="max-width: 100%">

<img
src="https://user-images.githubusercontent.com/76530270/213465432-f52e47fe-319a-49ac-bd9c-b2130f329db2.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/213465300-df7196ce-296f-4a88-b818-0a87521ce2c7.png"
height="400" style="max-width: 100%">



<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
None yet
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #4791 : Dark Mode the white corners of Stories Cards
2 participants
@MohitGupta121 @PratyushSingh07