Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for early exiting in the question player #501

Closed
BenHenning opened this issue Dec 2, 2019 · 7 comments · Fixed by #4928
Closed

Add support for early exiting in the question player #501

BenHenning opened this issue Dec 2, 2019 · 7 comments · Fixed by #4928
Assignees
@seanlip
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

If a learner gets their first five answers correct on their first try, they should be able to end the question training session early. See mocks: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/ec286faf-3a4f-4779-984a-17ca470842e6/TM-EN-5-out-of-10-.
@BenHenning BenHenning added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Dec 2, 2019
@rt4914
Copy link
Contributor

rt4914 commented Dec 9, 2019

In the mocks there is one line It looks like you may need to revisit certain things.
I think this line needs to be removed in this case.

@rt4914 rt4914 mentioned this issue Dec 9, 2019
Closed
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@ChiragKalra
Copy link
Contributor

I would like to work on this issue.

@rt4914
Copy link
Contributor

rt4914 commented Mar 19, 2021

@BenHenning Is this still valid issue?

@rt4914
Copy link
Contributor

rt4914 commented Mar 19, 2021

@ChiragKalra Suggest picking some other issue as it might be blocked on discussion.

@Broppia Broppia added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_feature labels Jul 29, 2022
@BenHenning
Copy link
Member Author

See #502 (comment).

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
Repository owner moved this from Needs Triage to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Sep 16, 2022
@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Sep 16, 2022
@github-actions github-actions bot reopened this Sep 16, 2022
@github-actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/app/src/main/java/org/oppia/android/app/topic/questionplayer/QuestionPlayerFragmentPresenter.kt

Line 329 in f99fa1d

// TODO(#501): Add support early exit detection & message, which requires changes in the training progress

@BenHenning
Copy link
Member Author

The AI here is the remove the TODO and close this issue.

@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip self-assigned this Mar 29, 2023
@seanlip seanlip mentioned this issue Mar 29, 2023
Merged
6 tasks
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
BenHenning pushed a commit that referenced this issue Mar 30, 2023
@seanlip
Fix #248, #501, #179, #762, #207: Remove obsolete TODOs. (#4928)
1c95dd3 
## Explanation

Fixes #248
Fixes #501
Fixes #179
Fixes #762
Fixes #207

This PR removes some obsolete TODOs so that the corresponding issues on
GitHub can be properly closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Uticodes pushed a commit to Uticodes/oppia-android that referenced this issue Apr 4, 2023
@seanlip @Uticodes
Fix oppia#248, oppia#501, oppia#179, oppia#762, oppia#207: Remove obs…
9a747f5 
…olete TODOs. (oppia#4928)

## Explanation

Fixes oppia#248
Fixes oppia#501
Fixes oppia#179
Fixes oppia#762
Fixes oppia#207

This PR removes some obsolete TODOs so that the corresponding issues on
GitHub can be properly closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanlip seanlip

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #248, #501, #179, #762, #207: Remove obsolete TODOs. oppia/oppia-android
5 participants
@rt4914 @seanlip @BenHenning @ChiragKalra @Broppia