-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ProfileChooserActivity to LoginActivity where necessary. #762
Comments
I think this isn't quite worth tracking at this point since remote profile support is not on the team's planned roadmap. Once it is, we'll need to revisit the integration with the entire app, including ProfileChooserActivity. |
The issue is reopened because of the following unresolved TODOs: Line 262 in f99fa1d
|
Ah, we'll need to remove that TODO. Triaging for now. |
Note to contributors: this is a very easy good first issue! It just involves removing the TODO. |
…olete TODOs. (oppia#4928) ## Explanation Fixes oppia#248 Fixes oppia#501 Fixes oppia#179 Fixes oppia#762 Fixes oppia#207 This PR removes some obsolete TODOs so that the corresponding issues on GitHub can be properly closed. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
This issue was brought up in PR #755 .As the login functionality is not implemented till now, currently we are redirecting user to ProfileActivity (Soon to be ProfileChooserActivity) in case if user wants to logout or exit the current account. So, once Login functionality is implemented, we need to redirect user to LoginActivityTo resolve this issue, remove the TODO corresponding to it per the TODO findings below.
The text was updated successfully, but these errors were encountered: