Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ProfileChooserActivity to LoginActivity where necessary. #762

Closed
Luffy18346 opened this issue Mar 9, 2020 · 4 comments · Fixed by #4928
Closed

Replace ProfileChooserActivity to LoginActivity where necessary. #762

Luffy18346 opened this issue Mar 9, 2020 · 4 comments · Fixed by #4928
Assignees
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Luffy18346
Copy link
Contributor

Luffy18346 commented Mar 9, 2020

This issue was brought up in PR #755 .

As the login functionality is not implemented till now, currently we are redirecting user to ProfileActivity (Soon to be ProfileChooserActivity) in case if user wants to logout or exit the current account. So, once Login functionality is implemented, we need to redirect user to LoginActivity

To resolve this issue, remove the TODO corresponding to it per the TODO findings below.

@rt4914 rt4914 changed the title Replace ProfileActivity to LoginActivity where necessary. Replace ProfileActivity to LoginActivity where necessary. [Blocked] Mar 10, 2020
@Luffy18346 Luffy18346 changed the title Replace ProfileActivity to LoginActivity where necessary. [Blocked] Replace ProfileChooserActivity to LoginActivity where necessary. [Blocked] Mar 10, 2020
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning
Copy link
Member

I think this isn't quite worth tracking at this point since remote profile support is not on the team's planned roadmap. Once it is, we'll need to revisit the integration with the entire app, including ProfileChooserActivity.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2022
@github-actions github-actions bot reopened this Sep 15, 2022
@github-actions
Copy link

The issue is reopened because of the following unresolved TODOs:

// TODO(#762): Replace [ProfileChooserActivity] to [LoginActivity] once it is added.

@BenHenning
Copy link
Member

Ah, we'll need to remove that TODO. Triaging for now.

@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip added good first issue This item is good for new contributors to make their pull request. enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@seanlip seanlip changed the title Replace ProfileChooserActivity to LoginActivity where necessary. [Blocked] Replace ProfileChooserActivity to LoginActivity where necessary. Mar 28, 2023
@seanlip
Copy link
Member

seanlip commented Mar 28, 2023

Note to contributors: this is a very easy good first issue! It just involves removing the TODO.

Uticodes pushed a commit to Uticodes/oppia-android that referenced this issue Apr 4, 2023
…olete TODOs. (oppia#4928)

## Explanation

Fixes oppia#248
Fixes oppia#501
Fixes oppia#179
Fixes oppia#762
Fixes oppia#207

This PR removes some obsolete TODOs so that the corresponding issues on
GitHub can be properly closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

4 participants