Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #659: Lowfi admin control part 3 logout appversion #755

Merged
merged 9 commits into from
Mar 10, 2020
Merged

Fix #659: Lowfi admin control part 3 logout appversion #755

merged 9 commits into from
Mar 10, 2020

Conversation

Luffy18346
Copy link
Contributor

Explanation

Fix #659 Lowfi admin control part 3: AppVersion and Logout

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Luffy18346 Luffy18346 requested a review from rt4914 March 7, 2020 15:52
rt4914
rt4914 suggested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But there are nit changes.

Also, click on back button in toolbar in AppVersionActivity is not working, fix that and also add test case of that.

@rt4914 rt4914 assigned Luffy18346 and unassigned rt4914 Mar 9, 2020
@Luffy18346 Luffy18346 mentioned this pull request Mar 9, 2020
Closed
@Luffy18346 Luffy18346 requested a review from rt4914 March 9, 2020 20:33
@Luffy18346 Luffy18346 assigned rt4914 and unassigned Luffy18346 Mar 9, 2020
rt4914
rt4914 suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit changes suggested.

@rt4914 rt4914 assigned Luffy18346 and unassigned rt4914 Mar 10, 2020
@Luffy18346 Luffy18346 requested a review from rt4914 March 10, 2020 08:36
@Luffy18346 Luffy18346 assigned rt4914 and unassigned Luffy18346 Mar 10, 2020
@Luffy18346
Copy link
Contributor Author

@rt4914 This is the AppVersion Screen. I am have not created any hifi branch for this screen because Its done according to mock already. If u find anything then please tell me.

Screenshot_2020-03-10-13-51-22-03_092c5771dc9bb06bcb5e5b6a9dadbf56 1

rt4914
rt4914 suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit final changes.

@rt4914 rt4914 assigned Luffy18346 and unassigned rt4914 Mar 10, 2020
@Luffy18346 Luffy18346 assigned rt4914 and unassigned Luffy18346 Mar 10, 2020
@Luffy18346 Luffy18346 requested a review from rt4914 March 10, 2020 10:53
rt4914
rt4914 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge your branch with latest develop and we can merge it after that.

rt4914
rt4914 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.

@rt4914 rt4914 assigned Luffy18346 and unassigned rt4914 Mar 10, 2020
@rt4914 rt4914 merged commit 1794f08 into oppia:develop Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@Luffy18346 Luffy18346

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lowfi Admin Controls (Part 3): AppVersion and Logout
2 participants
@Luffy18346 @rt4914