Fix #5034: Fix XML tags in translations and remove unnecessary quotation marks in CDATA strings. #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
added
the
PR: Cherrypick requested
|
I'm a bit too tired at the moment to review the actual code, but I'm happy to provide screenshots showing the behavior of this PR combined with #5040: The changes look really good from a functional perspective--thanks @seanlip! |
|
Unassigning @adhiamboperes since they have already approved the PR. |
|
Hi @seanlip, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
adhiamboperes
pushed a commit
to adhiamboperes/oppia-android
that referenced
this pull request
Jun 9, 2023
…uotation marks in CDATA strings. (oppia#5041) ## Explanation Fix oppia#5034: This PR fixes oppia#5034 by updating the translations in Arabic, PT-BR and Swahili. The corresponding translations have also been updated in translatewiki and should come in on the next push. This PR also removes some unnecessary quotation marks in CDATA tags in the English translations file. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only | English | Portuguese | Naija | Arabic | |---|---|---|---| ||||| | Landscape LTR | Landscape RTL | |---|---| |||
adhiamboperes
added
the
PR: Cherrypick completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix #5034: This PR fixes #5034 by updating the translations in Arabic, PT-BR and Swahili. The corresponding translations have also been updated in translatewiki and should come in on the next push.
This PR also removes some unnecessary quotation marks in CDATA tags in the English translations file.
Essential Checklist
For UI-specific PRs only