[WIP] Attempt to make optimas
generators compatible with generator standard
#228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall approach:
optimas
generators currently call theask
andtell
methods, which, under the hood, can the_ask
and_tell
methods.In this PR:
ask
/tell
are renamed toask_trials
/tell_trials
and keep the same interface (for compatibility with the rest of the framework)_ask
/_tell
are renamed toask
/tell
and adopt the new standardized interface.This allows other packages to use the
optimas
generators. (In this case, these other packages will call the new, standardizedask
/tell
directly, without going throughask_trials
/tell_trials
.)In order to wrap a standardized generator from another package, one would only need to make a thin wrapper around it that defines
ask_trials
andtell_trials
.