-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Attempt to make optimas
generators compatible with generator standard
#228
Open
RemiLehe
wants to merge
20
commits into
optimas-org:main
Choose a base branch
from
RemiLehe:standardization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
fbd8b0a
Rename tell to tell_trials
RemiLehe 2fc7992
Rename _tell to tell
RemiLehe db6e2bc
Rename ask to ask_trials
RemiLehe 522dd9c
Rename _ask to ask
RemiLehe 2445546
Convert ask to new format for simple generators
RemiLehe 0487226
Convert to tell format for simple generators
RemiLehe 55400dd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a879df1
Merge branch 'main' into standardization
RemiLehe cee853e
Fix bug
RemiLehe b29c7b5
Fix another bug
RemiLehe cb7a90e
Merge branch 'main' into standardization
RemiLehe d361865
Use new to_dict method
RemiLehe 2a8053e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] db32626
Update the ask method of the Ax service API
RemiLehe 687fe52
Merge branch 'standardization' of github.com:RemiLehe/optimas into st…
RemiLehe c233aa9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 38438bf
Add new `from_dict` method
RemiLehe d33ccb0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cd01075
Fix bug when trials have failed
RemiLehe e1022a3
Update optimas/core/trial.py
RemiLehe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to also pass the
id
here.